[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2862: ARI: Add subscription support
From: "Matt Jordan" <reviewboard () asterisk ! org>
Date: 2013-09-30 20:45:41
Message-ID: 20130930204541.7848.87318 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2862/#review9865
-----------------------------------------------------------
Ship it!
Ship It!
- Matt Jordan
On Sept. 27, 2013, 8:20 p.m., David Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2862/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2013, 8:20 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-22451
> https://issues.asterisk.org/jira/browse/ASTERISK-22451
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This patch adds an /applications API to ARI, allowing explicit management of
> Stasis applications.
>
> * GET /applications - list current applications
> * GET /applications/{applicationName} - get details of a specific application
> * POST /applications/{applicationName}/subscription - explicitly subscribe to
> a channel, bridge or endpoint
> * DELETE /applications/{applicationName}/subscription - explicitly unsubscribe
> from a channel, bridge or endpoint
>
> Subscriptions work by a reference counting mechanism: if you subscript to an
> event source X number of times, you must unsubscribe X number of times to stop
> receiveing events for that event source.
>
>
> Diffs
> -----
>
> /branches/12/include/asterisk/_private.h 399236
> /branches/12/include/asterisk/endpoints.h 399236
> /branches/12/include/asterisk/stasis_app.h 399236
> /branches/12/main/asterisk.c 399236
> /branches/12/main/endpoints.c 399236
> /branches/12/main/json.c 399236
> /branches/12/res/ari.make 399236
> /branches/12/res/ari/ari_model_validators.h 399236
> /branches/12/res/ari/ari_model_validators.c 399236
> /branches/12/res/ari/resource_applications.h PRE-CREATION
> /branches/12/res/ari/resource_applications.c PRE-CREATION
> /branches/12/res/ari/resource_endpoints.h 399236
> /branches/12/res/res_ari_applications.c PRE-CREATION
> /branches/12/res/res_ari_model.c 399236
> /branches/12/res/res_stasis.c 399236
> /branches/12/res/stasis/app.h 399236
> /branches/12/res/stasis/app.c 399236
> /branches/12/rest-api-templates/ari_model_validators.h.mustache 399236
> /branches/12/rest-api/api-docs/applications.json PRE-CREATION
> /branches/12/rest-api/api-docs/endpoints.json 399236
> /branches/12/rest-api/api-docs/events.json 399236
> /branches/12/rest-api/resources.json 399236
>
> Diff: https://reviewboard.asterisk.org/r/2862/diff/
>
>
> Testing
> -------
>
> Testsuite tests (https://reviewboard.asterisk.org/r/2863/)
>
> I hit a roadblock testing the endpoint subscription code, so that was tested
> manually using wscat and Swagger-UI.
>
>
> Thanks,
>
> David Lee
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2862/">https://reviewboard.asterisk.org/r/2862/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Matt</p>
<br />
<p>On September 27th, 2013, 8:20 p.m. UTC, David Lee wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated Sept. 27, 2013, 8:20 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22451">ASTERISK-22451</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds an /applications API to ARI, allowing explicit \
management of Stasis applications.
* GET /applications - list current applications
* GET /applications/{applicationName} - get details of a specific application
* POST /applications/{applicationName}/subscription - explicitly subscribe to
a channel, bridge or endpoint
* DELETE /applications/{applicationName}/subscription - explicitly unsubscribe
from a channel, bridge or endpoint
Subscriptions work by a reference counting mechanism: if you subscript to an
event source X number of times, you must unsubscribe X number of times to stop
receiveing events for that event source.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Testsuite tests (https://reviewboard.asterisk.org/r/2863/)
I hit a roadblock testing the endpoint subscription code, so that was tested
manually using wscat and Swagger-UI.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/12/include/asterisk/_private.h <span style="color: \
grey">(399236)</span></li>
<li>/branches/12/include/asterisk/endpoints.h <span style="color: \
grey">(399236)</span></li>
<li>/branches/12/include/asterisk/stasis_app.h <span style="color: \
grey">(399236)</span></li>
<li>/branches/12/main/asterisk.c <span style="color: grey">(399236)</span></li>
<li>/branches/12/main/endpoints.c <span style="color: grey">(399236)</span></li>
<li>/branches/12/main/json.c <span style="color: grey">(399236)</span></li>
<li>/branches/12/res/ari.make <span style="color: grey">(399236)</span></li>
<li>/branches/12/res/ari/ari_model_validators.h <span style="color: \
grey">(399236)</span></li>
<li>/branches/12/res/ari/ari_model_validators.c <span style="color: \
grey">(399236)</span></li>
<li>/branches/12/res/ari/resource_applications.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/branches/12/res/ari/resource_applications.c <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/branches/12/res/ari/resource_endpoints.h <span style="color: \
grey">(399236)</span></li>
<li>/branches/12/res/res_ari_applications.c <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/branches/12/res/res_ari_model.c <span style="color: grey">(399236)</span></li>
<li>/branches/12/res/res_stasis.c <span style="color: grey">(399236)</span></li>
<li>/branches/12/res/stasis/app.h <span style="color: grey">(399236)</span></li>
<li>/branches/12/res/stasis/app.c <span style="color: grey">(399236)</span></li>
<li>/branches/12/rest-api-templates/ari_model_validators.h.mustache <span \
style="color: grey">(399236)</span></li>
<li>/branches/12/rest-api/api-docs/applications.json <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/branches/12/rest-api/api-docs/endpoints.json <span style="color: \
grey">(399236)</span></li>
<li>/branches/12/rest-api/api-docs/events.json <span style="color: \
grey">(399236)</span></li>
<li>/branches/12/rest-api/resources.json <span style="color: \
grey">(399236)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2862/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic