'Re: [asterisk-dev] [Code Review] 2889: core: Reduce channel snapshotting and publishing.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 2889: core: Reduce channel snapshotting and publishing.
From:       "Joshua Colp" <reviewboard () asterisk ! org>
Date:       2013-09-28 15:50:31
Message-ID: 20130928155031.31996.57665 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2889/
-----------------------------------------------------------

(Updated Sept. 28, 2013, 3:50 p.m.)

Review request for Asterisk Developers.

Changes
-------

Added some staging to sig_pri and sig_ss7.

Repository: Asterisk

Description
-------

Currently many core operations implicitly create and publish a snapshot of the \
channel they are acting on. If you perform many of these operations together they \
each do this, which is wasteful. The attached patch adds the ability to mark a \
channel as staging a snapshot so the operations do not create and publish a snapshot. \
Once all operations are completed the staging is marked as done, and THEN the \
snapshot goes out. This reduces channel snapshotting and publishing by an average of \
50% on channel creation, origination, and hangup.

Diffs (updated)
-----

  /branches/12/apps/app_dial.c 399908 
  /branches/12/channels/chan_alsa.c 399908 
  /branches/12/channels/chan_console.c 399908 
  /branches/12/channels/chan_dahdi.c 399908 
  /branches/12/channels/chan_gtalk.c 399908 
  /branches/12/channels/chan_iax2.c 399908 
  /branches/12/channels/chan_jingle.c 399908 
  /branches/12/channels/chan_mgcp.c 399908 
  /branches/12/channels/chan_motif.c 399908 
  /branches/12/channels/chan_pjsip.c 399908 
  /branches/12/channels/chan_sip.c 399908 
  /branches/12/channels/chan_skinny.c 399908 
  /branches/12/channels/chan_unistim.c 399908 
  /branches/12/channels/sig_pri.c 399908 
  /branches/12/channels/sig_ss7.c 399908 
  /branches/12/include/asterisk/channel.h 399908 
  /branches/12/include/asterisk/stasis_channels.h 399908 
  /branches/12/main/bridge.c 399908 
  /branches/12/main/channel.c 399908 
  /branches/12/main/dial.c 399908 
  /branches/12/main/pbx.c 399908 
  /branches/12/main/stasis_channels.c 399908 

Diff: https://reviewboard.asterisk.org/r/2889/diff/

Testing
-------

Ran stuff, confirmed snapshots still go out.

Thanks,

Joshua Colp

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2889/">https://reviewboard.asterisk.org/r/2889/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>

<p style="color: grey;"><i>Updated Sept. 28, 2013, 3:50 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added some staging to sig_pri and sig_ss7.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently many core operations implicitly create and publish a snapshot \
of the channel they are acting on. If you perform many of these operations together \
they each do this, which is wasteful. The attached patch adds the ability to mark a \
channel as staging a snapshot so the operations do not create and publish a snapshot. \
Once all operations are completed the staging is marked as done, and THEN the \
snapshot goes out. This reduces channel snapshotting and publishing by an average of \
50% on channel creation, origination, and hangup.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran stuff, confirmed snapshots still go out.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/12/apps/app_dial.c <span style="color: grey">(399908)</span></li>

 <li>/branches/12/channels/chan_alsa.c <span style="color: grey">(399908)</span></li>

 <li>/branches/12/channels/chan_console.c <span style="color: \
grey">(399908)</span></li>

 <li>/branches/12/channels/chan_dahdi.c <span style="color: \
grey">(399908)</span></li>

 <li>/branches/12/channels/chan_gtalk.c <span style="color: \
grey">(399908)</span></li>

 <li>/branches/12/channels/chan_iax2.c <span style="color: grey">(399908)</span></li>

 <li>/branches/12/channels/chan_jingle.c <span style="color: \
grey">(399908)</span></li>

 <li>/branches/12/channels/chan_mgcp.c <span style="color: grey">(399908)</span></li>

 <li>/branches/12/channels/chan_motif.c <span style="color: \
grey">(399908)</span></li>

 <li>/branches/12/channels/chan_pjsip.c <span style="color: \
grey">(399908)</span></li>

 <li>/branches/12/channels/chan_sip.c <span style="color: grey">(399908)</span></li>

 <li>/branches/12/channels/chan_skinny.c <span style="color: \
grey">(399908)</span></li>

 <li>/branches/12/channels/chan_unistim.c <span style="color: \
grey">(399908)</span></li>

 <li>/branches/12/channels/sig_pri.c <span style="color: grey">(399908)</span></li>

 <li>/branches/12/channels/sig_ss7.c <span style="color: grey">(399908)</span></li>

 <li>/branches/12/include/asterisk/channel.h <span style="color: \
grey">(399908)</span></li>

 <li>/branches/12/include/asterisk/stasis_channels.h <span style="color: \
grey">(399908)</span></li>

 <li>/branches/12/main/bridge.c <span style="color: grey">(399908)</span></li>

 <li>/branches/12/main/channel.c <span style="color: grey">(399908)</span></li>

 <li>/branches/12/main/dial.c <span style="color: grey">(399908)</span></li>

 <li>/branches/12/main/pbx.c <span style="color: grey">(399908)</span></li>

 <li>/branches/12/main/stasis_channels.c <span style="color: \
grey">(399908)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2889/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

-- 
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 