[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2843: res_pjsip: crash when using localnet and external_signaling_a
From: "svnbot" <reviewboard () asterisk ! org>
Date: 2013-09-27 18:26:10
Message-ID: 20130927182610.27744.30183 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2843/
-----------------------------------------------------------
(Updated Sept. 27, 2013, 1:26 p.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Changes
-------
Committed in revision 399990
Bugs: ASTERISK-22394
https://issues.asterisk.org/jira/browse/ASTERISK-22394
Repository: Asterisk
Description
-------
There was a collision of mod_data use on the transaction between using a nat hook and \
an session response callback. During state change it was assumed what was in the \
mod_data was nothing or the response callback. However, it was possible for it to \
also contain a nat hook thus resulting in a bad cast and a crash.
Added the ability to store multiple data elements in mod_data via a hash table. In \
this instance, mod_data now stores a hash table of the two values that can be \
retrieved using an associated string key.
Diffs
-----
branches/12/res/res_pjsip_session.c 399893
branches/12/res/res_pjsip.exports.in 399893
branches/12/res/res_pjsip.c 399893
branches/12/include/asterisk/res_pjsip.h 399893
Diff: https://reviewboard.asterisk.org/r/2843/diff/
Testing
-------
Configured pjsip and made several calls to make sure the crash no longer occurred and \
everything still worked as expected with and without using the localnet and \
external_signaling_address_option(s).
Thanks,
Kevin Harwell
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2843/">https://reviewboard.asterisk.org/r/2843/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>
<p style="color: grey;"><i>Updated Sept. 27, 2013, 1:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Committed in revision 399990</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22394">ASTERISK-22394</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There was a collision of mod_data use on the transaction between using a \
nat hook and an session response callback. During state change it was assumed what \
was in the mod_data was nothing or the response callback. However, it was possible \
for it to also contain a nat hook thus resulting in a bad cast and a crash.
Added the ability to store multiple data elements in mod_data via a hash table. In \
this instance, mod_data now stores a hash table of the two values that can be \
retrieved using an associated string key.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Configured pjsip and made several calls to make sure the crash no longer \
occurred and everything still worked as expected with and without using the localnet \
and external_signaling_address_option(s).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/12/res/res_pjsip_session.c <span style="color: \
grey">(399893)</span></li>
<li>branches/12/res/res_pjsip.exports.in <span style="color: \
grey">(399893)</span></li>
<li>branches/12/res/res_pjsip.c <span style="color: grey">(399893)</span></li>
<li>branches/12/include/asterisk/res_pjsip.h <span style="color: \
grey">(399893)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2843/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic