'[asterisk-dev] [Code Review] 2812: Testsuite: Fix intermittent bridge test failures'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    [asterisk-dev] [Code Review] 2812: Testsuite: Fix intermittent bridge test failures
From:       "jrose" <reviewboard () asterisk ! org>
Date:       2013-08-30 19:09:27
Message-ID: 20130830190927.26576.84717 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2812/
-----------------------------------------------------------

Review request for Asterisk Developers, Matt Jordan, Mark Michelson, and rmudgett.

Repository: testsuite

Description
-------

Prior to this patch, bridge tests (I'm thinking all of them now) would fail \
intermittently in 12/trunk due to possible variance in entry order when it comes to \
receiving bridge entry events. This test module was written with the assumption that \
Alice would always enter first while testing revealed that it was possible (though \
slightly rare) for Bob to enter first. According to Richard, entry order one way or \
another is not guaranteed.

Diffs
-----

  /asterisk/trunk/lib/python/asterisk/BridgeTestCase.py 4081 

Diff: https://reviewboard.asterisk.org/r/2812/diff/

Testing
-------

Prior to patch:
   Ran bridge/parkcall_blindxfer test 25 times (test involves 5 separate call \
scenarios, so basically this is 125 tests against bridge_enter)  Test failed 6 of the \
25 times, each time due to Bob entering first.

Post patch:
   Ran bridge/parkcall_blindxfer test 25 times
   Test didn't fail ever.

Thanks,

jrose

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2812/">https://reviewboard.asterisk.org/r/2812/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers, Matt Jordan, Mark Michelson, and \
rmudgett.</div> <div>By jrose.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Prior to this patch, bridge tests (I&#39;m thinking all of them now) \
would fail intermittently in 12/trunk due to possible variance in entry order when it \
comes to receiving bridge entry events. This test module was written with the \
assumption that Alice would always enter first while testing revealed that it was \
possible (though slightly rare) for Bob to enter first. According to Richard, entry \
order one way or another is not guaranteed.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Prior to patch:  Ran bridge/parkcall_blindxfer test 25 times (test \
involves 5 separate call scenarios, so basically this is 125 tests against \
bridge_enter)  Test failed 6 of the 25 times, each time due to Bob entering first.

Post patch:
   Ran bridge/parkcall_blindxfer test 25 times
   Test didn&#39;t fail ever.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/asterisk/trunk/lib/python/asterisk/BridgeTestCase.py <span style="color: \
grey">(4081)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2812/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 