[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2731: Add database schema management using Alembic
From: "svnbot" <reviewboard () asterisk ! org>
Date: 2013-08-28 20:55:34
Message-ID: 20130828205534.13825.45673 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2731/
-----------------------------------------------------------
(Updated Aug. 28, 2013, 3:55 p.m.)
Status
------
This change has been marked as submitted.
Review request for Asterisk Developers.
Changes
-------
Committed in revision 397874
Repository: Asterisk
Description
-------
This patch replaces contrib/realtime/ with a new setup for managing the database \
schema required for database integration with Asterisk. In addition to initializing \
a database with the proper schema, alembic can do a database migration to assist with \
upgrading Asterisk in the future. Hopefully this helps make setting up and operating \
Asterisk with a database easier.
With this the schema only needs to be maintained in one place instead of once per \
database. The schemas I have added here have a bit of improvement over the examples \
that were there before (some added consistency and added some missing indexes). \
Managing the schema in one place here also applies to all databases supported by \
SQLAlchemy.
See contrib/ast-db-manage/README.md for more details.
Diffs
-----
/trunk/CHANGES 395934
/trunk/contrib/ast-db-manage/README.md PRE-CREATION
/trunk/contrib/ast-db-manage/config.ini.sample PRE-CREATION
/trunk/contrib/ast-db-manage/config/env.py PRE-CREATION
/trunk/contrib/ast-db-manage/config/script.py.mako PRE-CREATION
/trunk/contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py \
PRE-CREATION /trunk/contrib/ast-db-manage/voicemail.ini.sample PRE-CREATION
/trunk/contrib/ast-db-manage/voicemail/env.py PRE-CREATION
/trunk/contrib/ast-db-manage/voicemail/script.py.mako PRE-CREATION
/trunk/contrib/ast-db-manage/voicemail/versions/a2e9769475e_create_tables.py \
PRE-CREATION /trunk/contrib/realtime/mysql/iaxfriends.sql 395934
/trunk/contrib/realtime/mysql/meetme.sql 395934
/trunk/contrib/realtime/mysql/musiconhold.sql 395934
/trunk/contrib/realtime/mysql/queue_log.sql 395934
/trunk/contrib/realtime/mysql/sippeers.sql 395934
/trunk/contrib/realtime/mysql/voicemail.sql 395934
/trunk/contrib/realtime/mysql/voicemail_data.sql 395934
/trunk/contrib/realtime/mysql/voicemail_messages.sql 395934
/trunk/contrib/realtime/postgresql/realtime.sql 395934
Diff: https://reviewboard.asterisk.org/r/2731/diff/
Testing
-------
I ran schema upgrade/downgrade against MariaDB (MySQL compatible). The schema came \
out as expected. I haven't hooked it up to Asterisk, though...
Thanks,
Russell Bryant
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2731/">https://reviewboard.asterisk.org/r/2731/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;"> <tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1> </td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Russell Bryant.</div>
<p style="color: grey;"><i>Updated Aug. 28, 2013, 3:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Committed in revision 397874</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch replaces contrib/realtime/ with a new setup for managing the \
database schema required for database integration with Asterisk. In addition to \
initializing a database with the proper schema, alembic can do a database migration \
to assist with upgrading Asterisk in the future. Hopefully this helps make setting \
up and operating Asterisk with a database easier.
With this the schema only needs to be maintained in one place instead of once per \
database. The schemas I have added here have a bit of improvement over the examples \
that were there before (some added consistency and added some missing indexes). \
Managing the schema in one place here also applies to all databases supported by \
SQLAlchemy.
See contrib/ast-db-manage/README.md for more details.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I ran schema upgrade/downgrade against MariaDB (MySQL compatible). The \
schema came out as expected. I haven't hooked it up to Asterisk, though...</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/CHANGES <span style="color: grey">(395934)</span></li>
<li>/trunk/contrib/ast-db-manage/README.md <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/config.ini.sample <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/config/env.py <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/config/script.py.mako <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/voicemail.ini.sample <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/voicemail/env.py <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/voicemail/script.py.mako <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/ast-db-manage/voicemail/versions/a2e9769475e_create_tables.py \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/contrib/realtime/mysql/iaxfriends.sql <span style="color: \
grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/meetme.sql <span style="color: \
grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/musiconhold.sql <span style="color: \
grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/queue_log.sql <span style="color: \
grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/sippeers.sql <span style="color: \
grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/voicemail.sql <span style="color: \
grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/voicemail_data.sql <span style="color: \
grey">(395934)</span></li>
<li>/trunk/contrib/realtime/mysql/voicemail_messages.sql <span style="color: \
grey">(395934)</span></li>
<li>/trunk/contrib/realtime/postgresql/realtime.sql <span style="color: \
grey">(395934)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2731/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic