[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2699: pjsip tests: Test nominal inbound registrations with a single
From: "jbigelow" <reviewboard () asterisk ! org>
Date: 2013-07-31 22:10:27
Message-ID: 20130731221027.20938.3785 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2699/
-----------------------------------------------------------
(Updated July 31, 2013, 5:10 p.m.)
Review request for Asterisk Developers.
Changes
-------
Added checking of the expires parameter on the 200 OK and made it more tolerant as \
suggested on review 2718.
Repository: testsuite
Description
-------
This test sends registrations using a single contact with and without authentication \
over IPv4/IPv6 and UDP/TCP. This is to ensure that only a single contact is added to \
the AOR for each defined endpoint. This covers test #1 of the nominal inbound \
registrations listed on the test plan page of the wiki.
A single ast_test_suite_event_notify was added to res_pjsip_registrar.c to make this \
test possible. See review 2700 (https://reviewboard.asterisk.org/r/2700/)
Diffs (updated)
-----
/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/authed/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/authed/sipp/register-auth.xml \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/authed/configs/ast1/pjsip.conf \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/tests.yaml \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/unauthed/configs/ast1/pjsip.conf \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/unauthed/sipp/register-noauth.xml \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/unauthed/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/inbound/tests.yaml \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/tests.yaml \
PRE-CREATION /asterisk/trunk/tests/channels/pjsip/tests.yaml 3972
Diff: https://reviewboard.asterisk.org/r/2699/diff/
Testing
-------
* Ensured the tests fail if:
- the Test Events aren't received or do not match.
- the contact header in the 200 OK isn't what is expected
* Review logs to ensure that the registrations were using all the combinations of \
IPv4/IPv6 and UDP/TCP.
Thanks,
jbigelow
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2699/">https://reviewboard.asterisk.org/r/2699/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By jbigelow.</div>
<p style="color: grey;"><i>Updated July 31, 2013, 5:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added checking of the expires parameter on the 200 OK and made it more \
tolerant as suggested on review 2718.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This test sends registrations using a single contact with and without \
authentication over IPv4/IPv6 and UDP/TCP. This is to ensure that only a single \
contact is added to the AOR for each defined endpoint. This covers test #1 of the \
nominal inbound registrations listed on the test plan page of the wiki.
A single ast_test_suite_event_notify was added to res_pjsip_registrar.c to make this \
test possible. See review 2700 (https://reviewboard.asterisk.org/r/2700/)</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Ensured the tests fail if:
- the Test Events aren't received or do not match.
- the contact header in the 200 OK isn't what is expected
* Review logs to ensure that the registrations were using all the combinations of \
IPv4/IPv6 and UDP/TCP.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/authed/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/authed/sipp/register-auth.xml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/authed/configs/ast1/pjsip.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/tests.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/unauthed/configs/ast1/pjsip.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/unauthed/sipp/register-noauth.xml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/single_contact/unauthed/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/nominal/tests.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/inbound/tests.yaml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/registration/tests.yaml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/pjsip/tests.yaml <span style="color: \
grey">(3972)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2699/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic