'Re: [asterisk-dev] [Code Review] 2707: Reorganize SIP endpoint configuration structures'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 2707: Reorganize SIP endpoint configuration structures
From:       "svnbot" <reviewboard () asterisk ! org>
Date:       2013-07-30 15:18:01
Message-ID: 20130730151801.9995.85423 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2707/
-----------------------------------------------------------

(Updated July 30, 2013, 10:18 a.m.)

Status
------

This change has been marked as submitted.

Review request for Asterisk Developers and Joshua Colp.

Changes
-------

Committed in revision 395748

Bugs: ASTERISK-22135
    https://issues.asterisk.org/jira/browse/ASTERISK-22135

Repository: Asterisk

Description
-------

For the most part, this constitutes moving and sometimes renaming fields in the \
ast_sip_endpoint structure. The idea is to better organize the data into relevant \
categories. In addition, fields in the ast_sip_endpoint that were not used (domain, \
aor, and registrations) have been removed.

The only place where I allowed scope to creep was in relation to authentication. I \
noticed a tendency to pass an array of auth section names and the number of elements \
as parameters to functions. I also noticed several functions that were outright \
copied between sip_configuration.c and res_sip_outbound_registration.c with regards \
to authentication. So I created an ast_sip_auth_array structure that is now used as a \
common parameter for functions, and a couple of functions for populating and \
destroying the contents of the structures.

Diffs
-----

  /trunk/channels/chan_gulp.c 395553 
  /trunk/include/asterisk/res_sip.h 395553 
  /trunk/res/res_sip.c 395553 
  /trunk/res/res_sip.exports.in 395553 
  /trunk/res/res_sip/sip_configuration.c 395553 
  /trunk/res/res_sip/sip_distributor.c 395553 
  /trunk/res/res_sip/sip_options.c 395553 
  /trunk/res/res_sip/sip_outbound_auth.c 395553 
  /trunk/res/res_sip_authenticator_digest.c 395553 
  /trunk/res/res_sip_caller_id.c 395553 
  /trunk/res/res_sip_diversion.c 395553 
  /trunk/res/res_sip_messaging.c 395553 
  /trunk/res/res_sip_mwi.c 395553 
  /trunk/res/res_sip_nat.c 395553 
  /trunk/res/res_sip_one_touch_record_info.c 395553 
  /trunk/res/res_sip_outbound_authenticator_digest.c 395553 
  /trunk/res/res_sip_outbound_registration.c 395553 
  /trunk/res/res_sip_pubsub.c 395553 
  /trunk/res/res_sip_sdp_rtp.c 395553 
  /trunk/res/res_sip_session.c 395553 

Diff: https://reviewboard.asterisk.org/r/2707/diff/

Testing
-------

Code compiles, modules still load.

Thanks,

Mark Michelson

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2707/">https://reviewboard.asterisk.org/r/2707/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers and Joshua Colp.</div>
<div>By Mark Michelson.</div>

<p style="color: grey;"><i>Updated July 30, 2013, 10:18 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Committed in revision 395748</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-22135">ASTERISK-22135</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For the most part, this constitutes moving and sometimes renaming fields \
in the ast_sip_endpoint structure. The idea is to better organize the data into \
relevant categories. In addition, fields in the ast_sip_endpoint that were not used \
(domain, aor, and registrations) have been removed.

The only place where I allowed scope to creep was in relation to authentication. I \
noticed a tendency to pass an array of auth section names and the number of elements \
as parameters to functions. I also noticed several functions that were outright \
copied between sip_configuration.c and res_sip_outbound_registration.c with regards \
to authentication. So I created an ast_sip_auth_array structure that is now used as a \
common parameter for functions, and a couple of functions for populating and \
destroying the contents of the structures.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Code compiles, modules still load.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/channels/chan_gulp.c <span style="color: grey">(395553)</span></li>

 <li>/trunk/include/asterisk/res_sip.h <span style="color: grey">(395553)</span></li>

 <li>/trunk/res/res_sip.c <span style="color: grey">(395553)</span></li>

 <li>/trunk/res/res_sip.exports.in <span style="color: grey">(395553)</span></li>

 <li>/trunk/res/res_sip/sip_configuration.c <span style="color: \
grey">(395553)</span></li>

 <li>/trunk/res/res_sip/sip_distributor.c <span style="color: \
grey">(395553)</span></li>

 <li>/trunk/res/res_sip/sip_options.c <span style="color: grey">(395553)</span></li>

 <li>/trunk/res/res_sip/sip_outbound_auth.c <span style="color: \
grey">(395553)</span></li>

 <li>/trunk/res/res_sip_authenticator_digest.c <span style="color: \
grey">(395553)</span></li>

 <li>/trunk/res/res_sip_caller_id.c <span style="color: grey">(395553)</span></li>

 <li>/trunk/res/res_sip_diversion.c <span style="color: grey">(395553)</span></li>

 <li>/trunk/res/res_sip_messaging.c <span style="color: grey">(395553)</span></li>

 <li>/trunk/res/res_sip_mwi.c <span style="color: grey">(395553)</span></li>

 <li>/trunk/res/res_sip_nat.c <span style="color: grey">(395553)</span></li>

 <li>/trunk/res/res_sip_one_touch_record_info.c <span style="color: \
grey">(395553)</span></li>

 <li>/trunk/res/res_sip_outbound_authenticator_digest.c <span style="color: \
grey">(395553)</span></li>

 <li>/trunk/res/res_sip_outbound_registration.c <span style="color: \
grey">(395553)</span></li>

 <li>/trunk/res/res_sip_pubsub.c <span style="color: grey">(395553)</span></li>

 <li>/trunk/res/res_sip_sdp_rtp.c <span style="color: grey">(395553)</span></li>

 <li>/trunk/res/res_sip_session.c <span style="color: grey">(395553)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2707/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 