[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2697: ARI: Add recording controls
From: "David Lee" <reviewboard () asterisk ! org>
Date: 2013-07-29 22:05:20
Message-ID: 20130729220520.3452.5284 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2697/
-----------------------------------------------------------
(Updated July 29, 2013, 5:05 p.m.)
Review request for Asterisk Developers.
Changes
-------
Updated for trunk reorg.
Bugs: ASTERISK-22181
https://issues.asterisk.org/jira/browse/ASTERISK-22181
Repository: Asterisk
Description
-------
This patch implements the controls from ARI recordings. The controls
are:
* DELETE /recordings/live/{recordingName} - stop recording and
discard it
* POST /recordings/live/{recordingName}/stop - stop recording
* POST /recordings/live/{recordingName}/pause - pause recording
* POST /recordings/live/{recordingName}/unpause - resume recording
* POST /recordings/live/{recordingName}/mute - mute recording (record
silence to the file)
* POST /recordings/live/{recordingName}/unmute - unmute recording.
Since this underlying functionality did not already exist, is was
added to app.c by a set of control frames, similar to how playback
control works. The pause/mute control frames are toggles, even though
the ARI controls are idempotent, to be consistent with the playback
control frames.
Diffs (updated)
-----
/trunk/apps/app_minivm.c 395715
/trunk/apps/app_voicemail.c 395715
/trunk/funcs/func_frame_trace.c 395715
/trunk/include/asterisk/app.h 395715
/trunk/include/asterisk/frame.h 395715
/trunk/include/asterisk/stasis_app_recording.h 395715
/trunk/main/app.c 395715
/trunk/main/channel.c 395715
/trunk/res/ari/resource_recordings.h 395715
/trunk/res/ari/resource_recordings.c 395715
/trunk/res/res_ari_recordings.c 395715
/trunk/res/res_stasis_recording.c 395715
/trunk/rest-api/api-docs/recordings.json 395715
Diff: https://reviewboard.asterisk.org/r/2697/diff/
Testing
-------
Soooo many recordings.
Thanks,
David Lee
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2697/">https://reviewboard.asterisk.org/r/2697/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated July 29, 2013, 5:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Updated for trunk reorg.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-22181">ASTERISK-22181</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch implements the controls from ARI recordings. The controls \
are:
* DELETE /recordings/live/{recordingName} - stop recording and
discard it
* POST /recordings/live/{recordingName}/stop - stop recording
* POST /recordings/live/{recordingName}/pause - pause recording
* POST /recordings/live/{recordingName}/unpause - resume recording
* POST /recordings/live/{recordingName}/mute - mute recording (record
silence to the file)
* POST /recordings/live/{recordingName}/unmute - unmute recording.
Since this underlying functionality did not already exist, is was
added to app.c by a set of control frames, similar to how playback
control works. The pause/mute control frames are toggles, even though
the ARI controls are idempotent, to be consistent with the playback
control frames.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Soooo many recordings.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/apps/app_minivm.c <span style="color: grey">(395715)</span></li>
<li>/trunk/apps/app_voicemail.c <span style="color: grey">(395715)</span></li>
<li>/trunk/funcs/func_frame_trace.c <span style="color: grey">(395715)</span></li>
<li>/trunk/include/asterisk/app.h <span style="color: grey">(395715)</span></li>
<li>/trunk/include/asterisk/frame.h <span style="color: grey">(395715)</span></li>
<li>/trunk/include/asterisk/stasis_app_recording.h <span style="color: \
grey">(395715)</span></li>
<li>/trunk/main/app.c <span style="color: grey">(395715)</span></li>
<li>/trunk/main/channel.c <span style="color: grey">(395715)</span></li>
<li>/trunk/res/ari/resource_recordings.h <span style="color: \
grey">(395715)</span></li>
<li>/trunk/res/ari/resource_recordings.c <span style="color: \
grey">(395715)</span></li>
<li>/trunk/res/res_ari_recordings.c <span style="color: grey">(395715)</span></li>
<li>/trunk/res/res_stasis_recording.c <span style="color: grey">(395715)</span></li>
<li>/trunk/rest-api/api-docs/recordings.json <span style="color: \
grey">(395715)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2697/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic