[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 2630: res_sip_pubsub: Implement documented PUBLISH API.
From:       "svnbot" <reviewboard () asterisk ! org>
Date:       2013-06-29 13:42:31
Message-ID: 20130629134231.30398.63025 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2630/
-----------------------------------------------------------

(Updated June 29, 2013, 8:42 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers and Mark Michelson.


Changes
-------

Committed in revision 393262


Bugs: ASTERISK-21452
    https://issues.asterisk.org/jira/browse/ASTERISK-21452


Repository: Asterisk


Description
-------

The attached change implements the PUBLISH API for being an ESC as documented on the \
Asterisk wiki. The only changes involved were to add missing arguments to functions \
and to add a function for sending a response (from an API perspective).

What does this mean?

You can register publish handlers with res_sip_pubsub and they get invoked when \
certain things happen (new publish, terminated, expired, etc). Publish handlers \
specify the event they want and res_sip_pubsub dispatches accordingly. Note that \
res_sip_pubsub does *not* filter the content type. This is up to the handler.


Diffs
-----

  /team/group/pimp_my_sip/include/asterisk/res_sip_pubsub.h 391979 
  /team/group/pimp_my_sip/res/res_sip_pubsub.c 391979 
  /team/group/pimp_my_sip/res/res_sip_pubsub.exports.in 391979 

Diff: https://reviewboard.asterisk.org/r/2630/diff/


Testing
-------

I wrote a quick hack module (which I'm not attaching, cause it's really silly and \
useless) which accepts "presence" PUBLISH messages and spits out log messages when \
things happen. Confirmed that stuff works as expected using that.


Thanks,

Joshua Colp


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2630/">https://reviewboard.asterisk.org/r/2630/</a>
  </td>
    </tr>
   </table>
   <br />



<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
marked as submitted.</h1>  </td>
 </tr>
</table>
<br />


<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By Joshua Colp.</div>


<p style="color: grey;"><i>Updated June 29, 2013, 8:42 a.m.</i></p>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Committed in revision 393262</pre>  </td>
 </tr>
</table>





<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-21452">ASTERISK-21452</a>


</div>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The attached change implements the PUBLISH API for being an ESC as \
documented on the Asterisk wiki. The only changes involved were to add missing \
arguments to functions and to add a function for sending a response (from an API \
perspective).

What does this mean?

You can register publish handlers with res_sip_pubsub and they get invoked when \
certain things happen (new publish, terminated, expired, etc). Publish handlers \
specify the event they want and res_sip_pubsub dispatches accordingly. Note that \
res_sip_pubsub does *not* filter the content type. This is up to the handler.</pre>  \
</td>  </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I wrote a quick hack module (which I&#39;m not attaching, cause it&#39;s \
really silly and useless) which accepts &quot;presence&quot; PUBLISH messages and \
spits out log messages when things happen. Confirmed that stuff works as expected \
using that.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/team/group/pimp_my_sip/include/asterisk/res_sip_pubsub.h <span style="color: \
grey">(391979)</span></li>

 <li>/team/group/pimp_my_sip/res/res_sip_pubsub.c <span style="color: \
grey">(391979)</span></li>

 <li>/team/group/pimp_my_sip/res/res_sip_pubsub.exports.in <span style="color: \
grey">(391979)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2630/diff/" style="margin-left: \
3em;">View Diff</a></p>







  </td>
 </tr>
</table>




  </div>
 </body>
</html>



--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic