[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2641: ARI: Add support for getting/setting channel and global varia
From: "David Lee" <reviewboard () asterisk ! org>
Date: 2013-06-28 22:18:01
Message-ID: 20130628221801.27012.69339 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2641/#review9021
-----------------------------------------------------------
I wonder if it would be beneficial to model variables as a first class resource.
GET /channels/{channelId}/variables - returns all channel variables
GET /channels/{channelId}/variables/{variableName} - returns a single variable
POST /channels/{channelId}/variables/{variableName}?value=_ - sets a variable
And something similar for global variables. Functions become a little less intuitive, \
but this is probably more in the spirit of REST.
/trunk/res/stasis/control.c
<https://reviewboard.asterisk.org/r/2641/#comment17741>
Why not just char *workspace = ast_alloc(1024)? Then you can get rid of the \
strdup.
/trunk/res/stasis/control.c
<https://reviewboard.asterisk.org/r/2641/#comment17742>
You shouldn't have to cast variable to a char*. ast_func_read takes a const char \
*.
Regarding mjordan's earlier comment, if ast_func_read() fails, you should return \
NULL here.
/trunk/res/stasis/control.c
<https://reviewboard.asterisk.org/r/2641/#comment17743>
The doc for setvar_helper says "Will lock the channel." This lock isn't really \
needed.
/trunk/res/stasis_http/resource_asterisk.c
<https://reviewboard.asterisk.org/r/2641/#comment17744>
Ideally, you would return a 400 error code if the failure is the user's fault \
(trying to set a function that does not exist), or 500 if it's an internal error (a \
function unexpectedly failed).
setvar_helper really doesn't distinguish the two, so I would err on the side of \
the user making the mistake and always return a 400 error code here.
/trunk/res/stasis_http/resource_channels.c
<https://reviewboard.asterisk.org/r/2641/#comment17745>
Same comment here.
- David Lee
On June 27, 2013, 11:19 a.m., Jason Parker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2641/
> -----------------------------------------------------------
>
> (Updated June 27, 2013, 11:19 a.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-21868
> https://issues.asterisk.org/jira/browse/ASTERISK-21868
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Allows for reading channel variables (or functions), setting channel variables (or \
> functions), getting global variables, setting global variables.
>
> Diffs
> -----
>
> /trunk/include/asterisk/stasis_app.h 393055
> /trunk/res/res_stasis_http_asterisk.c 393055
> /trunk/res/res_stasis_http_channels.c 393055
> /trunk/res/stasis/control.c 393055
> /trunk/res/stasis_http/resource_asterisk.h 393055
> /trunk/res/stasis_http/resource_asterisk.c 393055
> /trunk/res/stasis_http/resource_channels.h 393055
> /trunk/res/stasis_http/resource_channels.c 393055
> /trunk/res/stasis_json/resource_asterisk.h 393055
> /trunk/res/stasis_json/resource_channels.h 393055
> /trunk/rest-api/api-docs/asterisk.json 393055
> /trunk/rest-api/api-docs/channels.json 393055
>
> Diff: https://reviewboard.asterisk.org/r/2641/diff/
>
>
> Testing
> -------
>
> All 4 things work. Failures occur in the few places they would be expected \
> (invalid function name, etc).
>
> Thanks,
>
> Jason Parker
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2641/">https://reviewboard.asterisk.org/r/2641/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I wonder if it would be \
beneficial to model variables as a first class resource.
GET /channels/{channelId}/variables - returns all channel variables
GET /channels/{channelId}/variables/{variableName} - returns a single variable
POST /channels/{channelId}/variables/{variableName}?value=_ - sets a variable
And something similar for global variables. Functions become a little less intuitive, \
but this is probably more in the spirit of REST.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2641/diff/3/?file=40511#file40511line140" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/res/stasis/control.c</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">140</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="kt">char</span> <span \
class="n">workspace</span><span class="p">[</span><span class="mi">1024</span><span \
class="p">];</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">141</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">142</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="n">ast_func_read</span><span \
class="p">(</span><span class="n">control</span><span class="o">-></span><span \
class="n">channel</span><span class="p">,</span> <span class="p">(</span><span \
class="kt">char</span> <span class="o">*</span><span class="p">)</span><span \
class="n">variable</span><span class="p">,</span> <span \
class="n">workspace</span><span class="p">,</span> <span class="k">sizeof</span><span \
class="p">(</span><span class="n">workspace</span><span \
class="p">));</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">143</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">144</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="n">value</span> <span \
class="o">=</span> <span class="n">ast_strdup</span><span class="p">(</span><span \
class="n">workspace</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why not \
just char *workspace = ast_alloc(1024)? Then you can get rid of the strdup.</pre> \
</div> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2641/diff/3/?file=40511#file40511line142" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/res/stasis/control.c</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">142</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="n">ast_func_read</span><span \
class="p">(</span><span class="n">control</span><span class="o">-></span><span \
class="n">channel</span><span class="p">,</span> <span class="p">(</span><span \
class="kt">char</span> <span class="o">*</span><span class="p">)</span><span \
class="n">variable</span><span class="p">,</span> <span \
class="n">workspace</span><span class="p">,</span> <span class="k">sizeof</span><span \
class="p">(</span><span class="n">workspace</span><span \
class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">You \
shouldn't have to cast variable to a char*. ast_func_read takes a const char *.
Regarding mjordan's earlier comment, if ast_func_read() fails, you should return \
NULL here.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2641/diff/3/?file=40511#file40511line154" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/res/stasis/control.c</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">154</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">SCOPED_CHANNELLOCK</span><span \
class="p">(</span><span class="n">lockvar</span><span class="p">,</span> <span \
class="n">control</span><span class="o">-></span><span \
class="n">channel</span><span class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">155</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="kt">int</span> <span class="n">ret</span><span \
class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">156</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">157</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">ret</span> <span class="o">=</span> <span \
class="n">pbx_builtin_setvar_helper</span><span class="p">(</span><span \
class="n">control</span><span class="o">-></span><span \
class="n">channel</span><span class="p">,</span> <span class="n">variable</span><span \
class="p">,</span> <span class="n">value</span><span class="p">);</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The doc for \
setvar_helper says "Will lock the channel." This lock isn't really \
needed.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2641/diff/3/?file=40513#file40513line63" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/res/stasis_http/resource_asterisk.c</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">63</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="k">if</span> <span class="p">(</span><span \
class="n">pbx_builtin_setvar_helper</span><span class="p">(</span><span \
class="nb">NULL</span><span class="p">,</span> <span class="n">args</span><span \
class="o">-></span><span class="n">variable</span><span class="p">,</span> <span \
class="n">args</span><span class="o">-></span><span class="n">value</span><span \
class="p">))</span> <span class="p">{</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">64</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span \
class="n">stasis_http_response_error</span><span class="p">(</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">65</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="n">response</span><span class="p">,</span> <span class="mi">500</span><span \
class="p">,</span> <span class="s">"Internal server error"</span><span \
class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">66</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="s">"Failed to set variable"</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">67</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="k">return</span><span \
class="p">;</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">68</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="p">}</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ideally, \
you would return a 400 error code if the failure is the user's fault (trying to \
set a function that does not exist), or 500 if it's an internal error (a function \
unexpectedly failed).
setvar_helper really doesn't distinguish the two, so I would err on the side of \
the user making the mistake and always return a 400 error code here.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2641/diff/3/?file=40515#file40515line425" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/res/stasis_http/resource_channels.c</a> <span style="font-weight: \
normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">425</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span \
class="n">stasis_http_response_error</span><span class="p">(</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">426</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="n">response</span><span class="p">,</span> <span class="mi">500</span><span \
class="p">,</span> <span class="s">"Internal server error"</span><span \
class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">427</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="s">"Failed to set variable"</span><span \
class="p">);</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">428</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="k">return</span><span \
class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same \
comment here.</pre> </div>
<br />
<p>- David</p>
<br />
<p>On June 27th, 2013, 11:19 a.m. CDT, Jason Parker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Jason Parker.</div>
<p style="color: grey;"><i>Updated June 27, 2013, 11:19 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21868">ASTERISK-21868</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Allows for reading channel variables (or functions), setting channel \
variables (or functions), getting global variables, setting global variables.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">All 4 things work. Failures occur in the few places they would be \
expected (invalid function name, etc).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/include/asterisk/stasis_app.h <span style="color: \
grey">(393055)</span></li>
<li>/trunk/res/res_stasis_http_asterisk.c <span style="color: \
grey">(393055)</span></li>
<li>/trunk/res/res_stasis_http_channels.c <span style="color: \
grey">(393055)</span></li>
<li>/trunk/res/stasis/control.c <span style="color: grey">(393055)</span></li>
<li>/trunk/res/stasis_http/resource_asterisk.h <span style="color: \
grey">(393055)</span></li>
<li>/trunk/res/stasis_http/resource_asterisk.c <span style="color: \
grey">(393055)</span></li>
<li>/trunk/res/stasis_http/resource_channels.h <span style="color: \
grey">(393055)</span></li>
<li>/trunk/res/stasis_http/resource_channels.c <span style="color: \
grey">(393055)</span></li>
<li>/trunk/res/stasis_json/resource_asterisk.h <span style="color: \
grey">(393055)</span></li>
<li>/trunk/res/stasis_json/resource_channels.h <span style="color: \
grey">(393055)</span></li>
<li>/trunk/rest-api/api-docs/asterisk.json <span style="color: \
grey">(393055)</span></li>
<li>/trunk/rest-api/api-docs/channels.json <span style="color: \
grey">(393055)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2641/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic