[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2592: testsuite: Create a basic test for call pickup
From: "jrose" <reviewboard () asterisk ! org>
Date: 2013-06-27 20:56:41
Message-ID: 20130627205641.21235.10707 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On June 27, 2013, 6:57 p.m., opticron wrote:
> > /asterisk/trunk/tests/feature_call_pickup/run-test, line 11
> > <https://reviewboard.asterisk.org/r/2592/diff/3/?file=40409#file40409line11>
> >
> > Unused import.
removed
- jrose
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2592/#review9001
-----------------------------------------------------------
On June 25, 2013, 10:05 p.m., jrose wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2592/
> -----------------------------------------------------------
>
> (Updated June 25, 2013, 10:05 p.m.)
>
>
> Review request for Asterisk Developers, kmoore and Matt Jordan.
>
>
> Bugs: ASTERISK-21544
> https://issues.asterisk.org/jira/browse/ASTERISK-21544
>
>
> Repository: testsuite
>
>
> Description
> -------
>
> This test is based roughly on the directed pickup application test (but that test \
> doesn't really work anymore). Basically it does the following:
> 1) A local channel is originated to an extension that will dial a SIP peer (faker). \
> This SIP peer points to an unused address, so it won't answer. 2) Once the dial \
> starts, Asterisk 2 dials Asterisk 1 via SIP to extension *8 (the pickup extension \
> assigned in features.conf) 3) At this point the SIP channel on Asterisk 2 \
> (sip_receive is its peername on Asterisk 1) should answer the call made by the \
> local channel since faker is in a callgroup set for use by sip_receive. Both \
> channels will then enter a simple bridge together.
> Once https://reviewboard.asterisk.org/r/2582/ is committed I can also add the \
> pickupsound being played as a condition for completing the test.
>
> Diffs
> -----
>
> /asterisk/trunk/tests/feature_call_pickup/configs/ast1/extensions.conf PRE-CREATION \
>
> /asterisk/trunk/tests/feature_call_pickup/configs/ast1/features.conf PRE-CREATION
> /asterisk/trunk/tests/feature_call_pickup/configs/ast1/sip.conf PRE-CREATION
> /asterisk/trunk/tests/feature_call_pickup/configs/ast2/extensions.conf PRE-CREATION \
>
> /asterisk/trunk/tests/feature_call_pickup/configs/ast2/sip.conf PRE-CREATION
> /asterisk/trunk/tests/feature_call_pickup/run-test PRE-CREATION
> /asterisk/trunk/tests/feature_call_pickup/test-config.yaml PRE-CREATION
> /asterisk/trunk/tests/tests.yaml 3820
>
> Diff: https://reviewboard.asterisk.org/r/2592/diff/
>
>
> Testing
> -------
>
> Ran it a few times and made sure what was happening matched with log messages after \
> the test was over. Made sure all pass conditions were actually met as well.
>
> Thanks,
>
> jrose
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2592/">https://reviewboard.asterisk.org/r/2592/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On June 27th, 2013, 6:57 p.m. UTC, <b>opticron</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2592/diff/3/?file=40409#file40409line11" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/asterisk/trunk/tests/feature_call_pickup/run-test</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">11</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">import \
os</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Unused import.</pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">removed</pre> <br />
<p>- jrose</p>
<br />
<p>On June 25th, 2013, 10:05 p.m. UTC, jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers, kmoore and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated June 25, 2013, 10:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21544">ASTERISK-21544</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This test is based roughly on the directed pickup application test (but \
that test doesn't really work anymore). Basically it does the following:
1) A local channel is originated to an extension that will dial a SIP peer (faker). \
This SIP peer points to an unused address, so it won't answer. 2) Once the dial \
starts, Asterisk 2 dials Asterisk 1 via SIP to extension *8 (the pickup extension \
assigned in features.conf) 3) At this point the SIP channel on Asterisk 2 \
(sip_receive is its peername on Asterisk 1) should answer the call made by the local \
channel since faker is in a callgroup set for use by sip_receive. Both channels will \
then enter a simple bridge together.
Once https://reviewboard.asterisk.org/r/2582/ is committed I can also add the \
pickupsound being played as a condition for completing the test.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran it a few times and made sure what was happening matched with log \
messages after the test was over. Made sure all pass conditions were actually met as \
well.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/feature_call_pickup/configs/ast1/extensions.conf <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/feature_call_pickup/configs/ast1/features.conf <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/feature_call_pickup/configs/ast1/sip.conf <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/feature_call_pickup/configs/ast2/extensions.conf <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/feature_call_pickup/configs/ast2/sip.conf <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/feature_call_pickup/run-test <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/feature_call_pickup/test-config.yaml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/tests.yaml <span style="color: grey">(3820)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2592/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic