[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2621: Shuffle RESTful URL's around
From: "opticron" <reviewboard () asterisk ! org>
Date: 2013-06-27 14:22:36
Message-ID: 20130627142236.4275.15854 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2621/#review8982
-----------------------------------------------------------
Ship it!
Ship It!
- opticron
On June 21, 2013, 5:09 p.m., David Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2621/
> -----------------------------------------------------------
>
> (Updated June 21, 2013, 5:09 p.m.)
>
>
> Review request for Asterisk Developers and Joshua Colp.
>
>
> Bugs: ASTERISK-21857
> https://issues.asterisk.org/jira/browse/ASTERISK-21857
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This patch moves the RESTful URL's around to more appropriate
> locations for release.
>
> The /stasis URL's are moved to /ari, since Asterisk RESTful Interface
> was a more appropriate name than Stasis-HTTP. (Most of the code still
> has stasis_http references, but they will be cleaned up after there
> are no more outstanding branches that would have merge conflicts with
> such a change).
>
> A larger change was moving the ARI events WebSocket off of the shared
> /ws URL to its permanent home on /ari/events. The Swagger code
> generator was extended to handle "upgrade: websocket" and
> "websocketProtocol:" attributes on an operation.
>
> The WebSocket module was modified to better handle WebSocket servers
> that have a single registered protocol handler. If a client
> connections does not specify the Sec-WebSocket-Protocol header, and
> the server has a single protocol handler registered, the WebSocket
> server will go ahead and accept the client for that subprotocol.
>
>
> Diffs
> -----
>
> /trunk/include/asterisk/stasis_http.h 392462
> /trunk/res/Makefile 392462
> /trunk/res/res_http_websocket.c 392462
> /trunk/res/res_http_websocket.exports.in 392462
> /trunk/res/res_stasis_http.c 392462
> /trunk/res/res_stasis_http.exports.in 392462
> /trunk/res/res_stasis_http_asterisk.c 392462
> /trunk/res/res_stasis_http_bridges.c 392462
> /trunk/res/res_stasis_http_channels.c 392462
> /trunk/res/res_stasis_http_endpoints.c 392462
> /trunk/res/res_stasis_http_events.c 392462
> /trunk/res/res_stasis_http_playback.c 392462
> /trunk/res/res_stasis_http_recordings.c 392462
> /trunk/res/res_stasis_http_sounds.c 392462
> /trunk/res/res_stasis_websocket.c 392462
> /trunk/res/stasis_http/ari_websockets.c PRE-CREATION
> /trunk/res/stasis_http/resource_events.h 392462
> /trunk/res/stasis_http/resource_events.c 392462
> /trunk/rest-api-templates/asterisk_processor.py 392462
> /trunk/rest-api-templates/param_parsing.mustache PRE-CREATION
> /trunk/rest-api-templates/res_stasis_http_resource.c.mustache 392462
> /trunk/rest-api-templates/rest_handler.mustache 392462
> /trunk/rest-api-templates/stasis_http_resource.c.mustache 392462
> /trunk/rest-api-templates/stasis_http_resource.h.mustache 392462
> /trunk/rest-api-templates/swagger_model.py 392462
> /trunk/rest-api/api-docs/events.json 392462
> /trunk/tests/test_stasis_http.c 392462
>
> Diff: https://reviewboard.asterisk.org/r/2621/diff/
>
>
> Testing
> -------
>
> * Ran some ARI tests against /ari/events
> * Specifying the 'ari' subprotocol
> * Specifying no subprotocol
> * Specifying any other subprotocol got a 400 response
> * Verified that connecting to /ws echo subprotocol still worked
>
>
> Thanks,
>
> David Lee
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2621/">https://reviewboard.asterisk.org/r/2621/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- opticron</p>
<br />
<p>On June 21st, 2013, 5:09 p.m. CDT, David Lee wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers and Joshua Colp.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated June 21, 2013, 5:09 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21857">ASTERISK-21857</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch moves the RESTful URL's around to more appropriate \
locations for release.
The /stasis URL's are moved to /ari, since Asterisk RESTful Interface
was a more appropriate name than Stasis-HTTP. (Most of the code still
has stasis_http references, but they will be cleaned up after there
are no more outstanding branches that would have merge conflicts with
such a change).
A larger change was moving the ARI events WebSocket off of the shared
/ws URL to its permanent home on /ari/events. The Swagger code
generator was extended to handle "upgrade: websocket" and
"websocketProtocol:" attributes on an operation.
The WebSocket module was modified to better handle WebSocket servers
that have a single registered protocol handler. If a client
connections does not specify the Sec-WebSocket-Protocol header, and
the server has a single protocol handler registered, the WebSocket
server will go ahead and accept the client for that subprotocol.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Ran some ARI tests against /ari/events
* Specifying the 'ari' subprotocol
* Specifying no subprotocol
* Specifying any other subprotocol got a 400 response
* Verified that connecting to /ws echo subprotocol still worked
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/include/asterisk/stasis_http.h <span style="color: \
grey">(392462)</span></li>
<li>/trunk/res/Makefile <span style="color: grey">(392462)</span></li>
<li>/trunk/res/res_http_websocket.c <span style="color: grey">(392462)</span></li>
<li>/trunk/res/res_http_websocket.exports.in <span style="color: \
grey">(392462)</span></li>
<li>/trunk/res/res_stasis_http.c <span style="color: grey">(392462)</span></li>
<li>/trunk/res/res_stasis_http.exports.in <span style="color: \
grey">(392462)</span></li>
<li>/trunk/res/res_stasis_http_asterisk.c <span style="color: \
grey">(392462)</span></li>
<li>/trunk/res/res_stasis_http_bridges.c <span style="color: \
grey">(392462)</span></li>
<li>/trunk/res/res_stasis_http_channels.c <span style="color: \
grey">(392462)</span></li>
<li>/trunk/res/res_stasis_http_endpoints.c <span style="color: \
grey">(392462)</span></li>
<li>/trunk/res/res_stasis_http_events.c <span style="color: \
grey">(392462)</span></li>
<li>/trunk/res/res_stasis_http_playback.c <span style="color: \
grey">(392462)</span></li>
<li>/trunk/res/res_stasis_http_recordings.c <span style="color: \
grey">(392462)</span></li>
<li>/trunk/res/res_stasis_http_sounds.c <span style="color: \
grey">(392462)</span></li>
<li>/trunk/res/res_stasis_websocket.c <span style="color: grey">(392462)</span></li>
<li>/trunk/res/stasis_http/ari_websockets.c <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/res/stasis_http/resource_events.h <span style="color: \
grey">(392462)</span></li>
<li>/trunk/res/stasis_http/resource_events.c <span style="color: \
grey">(392462)</span></li>
<li>/trunk/rest-api-templates/asterisk_processor.py <span style="color: \
grey">(392462)</span></li>
<li>/trunk/rest-api-templates/param_parsing.mustache <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/rest-api-templates/res_stasis_http_resource.c.mustache <span \
style="color: grey">(392462)</span></li>
<li>/trunk/rest-api-templates/rest_handler.mustache <span style="color: \
grey">(392462)</span></li>
<li>/trunk/rest-api-templates/stasis_http_resource.c.mustache <span style="color: \
grey">(392462)</span></li>
<li>/trunk/rest-api-templates/stasis_http_resource.h.mustache <span style="color: \
grey">(392462)</span></li>
<li>/trunk/rest-api-templates/swagger_model.py <span style="color: \
grey">(392462)</span></li>
<li>/trunk/rest-api/api-docs/events.json <span style="color: \
grey">(392462)</span></li>
<li>/trunk/tests/test_stasis_http.c <span style="color: grey">(392462)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2621/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic