[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2584: New SIP Channel Driver - SIP Qualify Support
From: "opticron" <reviewboard () asterisk ! org>
Date: 2013-05-31 20:20:05
Message-ID: 20130531202005.25520.85634 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2584/#review8747
-----------------------------------------------------------
/team/group/pimp_my_sip/res/res_sip/location.c
<https://reviewboard.asterisk.org/r/2584/#comment17145>
XML documentation needs to be updated to reflect this change.
/team/group/pimp_my_sip/res/res_sip/sip_configuration.c
<https://reviewboard.asterisk.org/r/2584/#comment17146>
Idem.
- opticron
On May 31, 2013, 3:05 p.m., Kevin Harwell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2584/
> -----------------------------------------------------------
>
> (Updated May 31, 2013, 3:05 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-21499
> https://issues.asterisk.org/jira/browse/ASTERISK-21499
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Completed the work that had been started for SIP qualify support in the new channel \
> driver. Qualify requests are now sent for every contact associated with an \
> endpoint. When a contact is registered a check is done to make sure it is \
> available and the round trip time is stored for reference. The contact continues \
> to be checked at a specified interval (qualify_frequency - now set on the AOR) \
> until it is removed.
> A CLI command ("sip qualify <endpoint>") is also available that when issued will \
> send qualifies for all contacts on the given endpoint. Also added CLI command "sip \
> show endpoint <endpoint>" that will show all the contacts and their status for the \
> given endpoint.
>
> Diffs
> -----
>
> /team/group/pimp_my_sip/include/asterisk/res_sip.h 390336
> /team/group/pimp_my_sip/res/res_sip.c 390336
> /team/group/pimp_my_sip/res/res_sip/location.c 390336
> /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 390336
> /team/group/pimp_my_sip/res/res_sip/sip_options.c 390336
> /team/group/pimp_my_sip/res/res_sip_registrar.c 390336
>
> Diff: https://reviewboard.asterisk.org/r/2584/diff/
>
>
> Testing
> -------
>
> Manually tested by registering contacts and making sure the qualify requests were \
> sent out and scheduled.
>
> Thanks,
>
> Kevin Harwell
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2584/">https://reviewboard.asterisk.org/r/2584/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2584/diff/2/?file=38912#file38912line298" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/team/res/res_sip/location.c</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
ast_sip_initialize_sorcery_location(struct ast_sorcery *sorcery)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">298</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">ast_sorcery_object_field_register</span><span \
class="p">(</span><span class="n">sorcery</span><span class="p">,</span> <span \
class="s">"contact"</span><span class="p">,</span> <span \
class="s">"qualify_frequency"</span><span class="p">,</span> <span \
class="mi">0</span><span class="p">,</span> <span class="n">OPT_UINT_T</span><span \
class="p">,</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">299</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="tb"> </span><span class="tb"> </span><span \
class="tb"> </span><span class="tb"> </span> <span \
class="n">PARSE_IN_RANGE</span><span class="p">,</span> <span \
class="n">FLDSET</span><span class="p">(</span><span class="k">struct</span> <span \
class="n">ast_sip_aor</span><span class="p">,</span> <span \
class="n">qualify_frequency</span><span class="p">),</span> <span \
class="mi">0</span><span class="p">,</span> <span class="mi">86400</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">297</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">300</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">298</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">ast_sorcery_object_field_register</span><span class="p">(</span><span \
class="n">sorcery</span><span class="p">,</span> <span \
class="s">"aor"</span><span class="p">,</span> <span \
class="s">"type"</span><span class="p">,</span> <span \
class="s">""</span><span class="p">,</span> <span \
class="n">OPT_NOOP_T</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">,</span> <span class="mi">0</span><span class="p">);</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">301</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">ast_sorcery_object_field_register</span><span \
class="p">(</span><span class="n">sorcery</span><span class="p">,</span> <span \
class="s">"aor"</span><span class="p">,</span> <span \
class="s">"type"</span><span class="p">,</span> <span \
class="s">""</span><span class="p">,</span> <span \
class="n">OPT_NOOP_T</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">,</span> <span class="mi">0</span><span class="p">);</span></pre></td> \
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">299</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">ast_sorcery_object_field_register</span><span class="p">(</span><span \
class="n">sorcery</span><span class="p">,</span> <span \
class="s">"aor"</span><span class="p">,</span> <span \
class="s">"minimum_expiration"</span><span class="p">,</span> <span \
class="s">"60"</span><span class="p">,</span> <span \
class="n">OPT_UINT_T</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">,</span> <span class="n">FLDSET</span><span class="p">(</span><span \
class="k">struct</span> <span class="n">ast_sip_aor</span><span class="p">,</span> \
<span class="n">minimum_expiration</span><span class="p">));</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">302</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">ast_sorcery_object_field_register</span><span \
class="p">(</span><span class="n">sorcery</span><span class="p">,</span> <span \
class="s">"aor"</span><span class="p">,</span> <span \
class="s">"minimum_expiration"</span><span class="p">,</span> <span \
class="s">"60"</span><span class="p">,</span> <span \
class="n">OPT_UINT_T</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">,</span> <span class="n">FLDSET</span><span class="p">(</span><span \
class="k">struct</span> <span class="n">ast_sip_aor</span><span class="p">,</span> \
<span class="n">minimum_expiration</span><span class="p">));</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">300</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">ast_sorcery_object_field_register</span><span class="p">(</span><span \
class="n">sorcery</span><span class="p">,</span> <span \
class="s">"aor"</span><span class="p">,</span> <span \
class="s">"maximum_expiration"</span><span class="p">,</span> <span \
class="s">"7200"</span><span class="p">,</span> <span \
class="n">OPT_UINT_T</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">,</span> <span class="n">FLDSET</span><span class="p">(</span><span \
class="k">struct</span> <span class="n">ast_sip_aor</span><span class="p">,</span> \
<span class="n">maximum_expiration</span><span class="p">));</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">303</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">ast_sorcery_object_field_register</span><span \
class="p">(</span><span class="n">sorcery</span><span class="p">,</span> <span \
class="s">"aor"</span><span class="p">,</span> <span \
class="s">"maximum_expiration"</span><span class="p">,</span> <span \
class="s">"7200"</span><span class="p">,</span> <span \
class="n">OPT_UINT_T</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">,</span> <span class="n">FLDSET</span><span class="p">(</span><span \
class="k">struct</span> <span class="n">ast_sip_aor</span><span class="p">,</span> \
<span class="n">maximum_expiration</span><span class="p">));</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">301</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">ast_sorcery_object_field_register</span><span class="p">(</span><span \
class="n">sorcery</span><span class="p">,</span> <span \
class="s">"aor"</span><span class="p">,</span> <span \
class="s">"default_expiration"</span><span class="p">,</span> <span \
class="s">"3600"</span><span class="p">,</span> <span \
class="n">OPT_UINT_T</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">,</span> <span class="n">FLDSET</span><span class="p">(</span><span \
class="k">struct</span> <span class="n">ast_sip_aor</span><span class="p">,</span> \
<span class="n">default_expiration</span><span class="p">));</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">304</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">ast_sorcery_object_field_register</span><span \
class="p">(</span><span class="n">sorcery</span><span class="p">,</span> <span \
class="s">"aor"</span><span class="p">,</span> <span \
class="s">"default_expiration"</span><span class="p">,</span> <span \
class="s">"3600"</span><span class="p">,</span> <span \
class="n">OPT_UINT_T</span><span class="p">,</span> <span class="mi">0</span><span \
class="p">,</span> <span class="n">FLDSET</span><span class="p">(</span><span \
class="k">struct</span> <span class="n">ast_sip_aor</span><span class="p">,</span> \
<span class="n">default_expiration</span><span class="p">));</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">305</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="tb"> </span><span class="n">ast_sorcery_object_field_register</span><span \
class="p">(</span><span class="n">sorcery</span><span class="p">,</span> <span \
class="s">"aor"</span><span class="p">,</span> <span \
class="s">"qualify_frequency"</span><span class="p">,</span> <span \
class="mi">0</span><span class="p">,</span> <span class="n">OPT_UINT_T</span><span \
class="p">,</span> <span class="n">PARSE_IN_RANGE</span><span class="p">,</span> \
<span class="n">FLDSET</span><span class="p">(</span><span class="k">struct</span> \
<span class="n">ast_sip_aor</span><span class="p">,</span> <span \
class="n">qualify_frequency</span><span class="p">),</span> <span \
class="mi">0</span><span class="p">,</span> <span class="mi">86400</span><span \
class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">XML \
documentation needs to be updated to reflect this change.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2584/diff/2/?file=38913#file38913line338" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/team/res/res_sip/sip_configuration.c</a> <span style="font-weight: \
normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">int \
ast_res_sip_initialize_configuration(void)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">338</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span \
class="n">ast_sorcery_object_field_register</span><span class="p">(</span><span \
class="n">sip_sorcery</span><span class="p">,</span> <span \
class="s">"endpoint"</span><span class="p">,</span> <span \
class="s">"qualify_frequency"</span><span class="p">,</span> <span \
class="mi">0</span><span class="p">,</span> <span class="n">OPT_UINT_T</span><span \
class="p">,</span> <span class="n">PARSE_IN_RANGE</span><span class="p">,</span> \
<span class="n">FLDSET</span><span class="p">(</span><span class="k">struct</span> \
<span class="n">ast_sip_endpoint</span><span class="p">,</span> <span \
class="n">qualify_frequency</span><span class="p">),</span> <span \
class="mi">0</span><span class="p">,</span> <span class="mi">86400</span><span \
class="p">);</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Idem.</pre> \
</div> <br />
<p>- opticron</p>
<br />
<p>On May 31st, 2013, 3:05 p.m. CDT, Kevin Harwell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>
<p style="color: grey;"><i>Updated May 31, 2013, 3:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21499">ASTERISK-21499</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Completed the work that had been started for SIP qualify support in the \
new channel driver. Qualify requests are now sent for every contact associated with \
an endpoint. When a contact is registered a check is done to make sure it is \
available and the round trip time is stored for reference. The contact continues to \
be checked at a specified interval (qualify_frequency - now set on the AOR) until it \
is removed.
A CLI command ("sip qualify <endpoint>") is also available that when \
issued will send qualifies for all contacts on the given endpoint. Also added CLI \
command "sip show endpoint <endpoint>" that will show all the \
contacts and their status for the given endpoint.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Manually tested by registering contacts and making sure the qualify \
requests were sent out and scheduled.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/group/pimp_my_sip/include/asterisk/res_sip.h <span style="color: \
grey">(390336)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip.c <span style="color: \
grey">(390336)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip/location.c <span style="color: \
grey">(390336)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip/sip_configuration.c <span style="color: \
grey">(390336)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip/sip_options.c <span style="color: \
grey">(390336)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip_registrar.c <span style="color: \
grey">(390336)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2584/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic