'Re: [asterisk-dev] [Code Review] 2564: app_meetme: manager events to stasis'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 2564: app_meetme: manager events to stasis
From:       "jrose" <reviewboard () asterisk ! org>
Date:       2013-05-31 16:39:51
Message-ID: 20130531163951.15357.57902 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2564/
-----------------------------------------------------------

(Updated May 31, 2013, 4:39 p.m.)

Review request for Asterisk Developers, kmoore and Matt Jordan.

Changes
-------

Address Jason's findings.

Bugs: ASTERISK-21467
    https://issues.asterisk.org/jira/browse/ASTERISK-21467

Repository: Asterisk

Description
-------

Refactor the events for app_meetme to go through stasis similar to confbridge.

Since there aren't any bridges involved, everything goes through channel topics \
(which is a little odd since some of the events don't actually involve channels, in \
which case they go out over the all channel topic, but since only meetme responds to \
the meetme message type anyway, it doesn't really matter).

Diffs (updated)
-----

  /trunk/apps/app_meetme.c 390154 
  /trunk/apps/confbridge/confbridge_manager.c 390154 
  /trunk/include/asterisk/manager.h 390154 
  /trunk/main/manager.c 390154 

Diff: https://reviewboard.asterisk.org/r/2564/diff/

Testing
-------

Checked that each event type gets properly relayed over AMI with all of the expected \
fields.

Thanks,

jrose

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2564/">https://reviewboard.asterisk.org/r/2564/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers, kmoore and Matt Jordan.</div>
<div>By jrose.</div>

<p style="color: grey;"><i>Updated May 31, 2013, 4:39 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Address Jason&#39;s findings.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-21467">ASTERISK-21467</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Refactor the events for app_meetme to go through stasis similar to \
confbridge.

Since there aren&#39;t any bridges involved, everything goes through channel topics \
(which is a little odd since some of the events don&#39;t actually involve channels, \
in which case they go out over the all channel topic, but since only meetme responds \
to the meetme message type anyway, it doesn&#39;t really matter).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Checked that each event type gets properly relayed over AMI with all of \
the expected fields.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/apps/app_meetme.c <span style="color: grey">(390154)</span></li>

 <li>/trunk/apps/confbridge/confbridge_manager.c <span style="color: \
grey">(390154)</span></li>

 <li>/trunk/include/asterisk/manager.h <span style="color: grey">(390154)</span></li>

 <li>/trunk/main/manager.c <span style="color: grey">(390154)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2564/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 