'[asterisk-dev] [Code Review] 2570: Finish Gulp Connected Line Support'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    [asterisk-dev] [Code Review] 2570: Finish Gulp Connected Line Support
From:       "Joshua Colp" <reviewboard () asterisk ! org>
Date:       2013-05-29 18:12:49
Message-ID: 20130529181249.28760.87164 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2570/
-----------------------------------------------------------

Review request for Asterisk Developers.

Bugs: ASTERISK-21258
    https://issues.asterisk.org/jira/browse/ASTERISK-21258

Repository: Asterisk

Description
-------

This change implements handling of the connected line indication. This entails \
sending responses if possible, or sending requests (INVITE / UPDATE). The existing \
callerid code handles adding the information (and it does it marvelously).

Diffs
-----

  /team/group/pimp_my_sip/channels/chan_gulp.c 390033 
  /team/group/pimp_my_sip/include/asterisk/res_sip.h 390033 
  /team/group/pimp_my_sip/res/res_sip.c 390033 
  /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 390033 
  /team/group/pimp_my_sip/res/res_sip_caller_id.c 390033 

Diff: https://reviewboard.asterisk.org/r/2570/diff/

Testing
-------

Tested various scenarios to ensure that the problem information is sent.

Thanks,

Joshua Colp

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2570/">https://reviewboard.asterisk.org/r/2570/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-21258">ASTERISK-21258</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This change implements handling of the connected line indication. This \
entails sending responses if possible, or sending requests (INVITE / UPDATE). The \
existing callerid code handles adding the information (and it does it \
marvelously).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested various scenarios to ensure that the problem information is \
sent.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/team/group/pimp_my_sip/channels/chan_gulp.c <span style="color: \
grey">(390033)</span></li>

 <li>/team/group/pimp_my_sip/include/asterisk/res_sip.h <span style="color: \
grey">(390033)</span></li>

 <li>/team/group/pimp_my_sip/res/res_sip.c <span style="color: \
grey">(390033)</span></li>

 <li>/team/group/pimp_my_sip/res/res_sip/sip_configuration.c <span style="color: \
grey">(390033)</span></li>

 <li>/team/group/pimp_my_sip/res/res_sip_caller_id.c <span style="color: \
grey">(390033)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2570/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 