[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2447: res_parking: Rebuilding parking from the ground up to work wi
From: "jrose" <reviewboard () asterisk ! org>
Date: 2013-04-30 18:45:00
Message-ID: 20130430184500.6155.49320 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2447/
-----------------------------------------------------------
(Updated April 30, 2013, 6:44 p.m.)
Review request for Asterisk Developers, David Lee, kmoore, Matt Jordan, Mark \
Michelson, and rmudgett.
Changes
-------
Address the last round of review feedback.
Bugs: ASTERISK-21059, ASTERISK-21272 and ASTERISK-21353
https://issues.asterisk.org/jira/browse/ASTERISK-21059
https://issues.asterisk.org/jira/browse/ASTERISK-21272
https://issues.asterisk.org/jira/browse/ASTERISK-21353
Repository: Asterisk
Description
-------
As a result of all the new bridging changes, certain applications such as parking, \
queues, confbridge, and a few others require significant reworking within Asterisk to \
make usable. Parking was less than salvagable, so I've rebuilt it from the ground up \
to use a lot of new stuff including config hooks, the new bridging architecture, \
stasis, and just generally to be an independent module with its own scope that \
doesn't get tangled into a giant morass within features.c
Parking configuration works somewhat differently now and extensions aren't \
necessarily automatically generated (it's optional and hasn't been implemented), but \
the intention with the final result is that if you were using parking before without \
too much additional dialplan manipulation, that should all just work once your \
parking lots are migrated to the new configuration file.
Currently supported:
parking from the PBX with the Park application (all arguments are supported)
parking within a call using the one touch parking feature
parking within a call using DTMF blind transfers (attended transfers work, but it's \
basically just like they called the application itself). Picking up parked calls \
using the PBX Multiple parking lots
All options available to parking lots are currently configurable. Some aren't \
currently doing anything, namely parkext and hints.
To do list:
* Dialplan generation for parking lots with parkext (included 'Park' and 'ParkedCall' \
applications)
* Dialplan generation for comebacktoorigin (park-dial extensions)
* Hints
* Implement 'Park' manager action
* Dynamic parking lots and the default parking lot
* Scraping the greasy remnants of parking out of features.c
* CEL events
* Unit tests and testsuite tests
Diffs (updated)
-----
/team/group/bridge_construction/include/asterisk/parking.h PRE-CREATION
/team/group/bridge_construction/main/bridging.c 387012
/team/group/bridge_construction/main/bridging_roles.c 387012
/team/group/bridge_construction/main/config_options.c 387012
/team/group/bridge_construction/main/features.c 387012
/team/group/bridge_construction/main/parking.c PRE-CREATION
/team/group/bridge_construction/res/Makefile 387012
/team/group/bridge_construction/res/parking/parking_applications.c PRE-CREATION
/team/group/bridge_construction/include/asterisk/config_options.h 387012
/team/group/bridge_construction/include/asterisk/bridging.h 387012
/team/group/bridge_construction/configs/res_parking.conf.sample PRE-CREATION
/team/group/bridge_construction/bridges/bridge_builtin_features.c 387012
/team/group/bridge_construction/CHANGES 387012
/team/group/bridge_construction/res/parking/parking_bridge.c PRE-CREATION
/team/group/bridge_construction/res/parking/parking_bridge_features.c PRE-CREATION
/team/group/bridge_construction/res/parking/parking_controller.c PRE-CREATION
/team/group/bridge_construction/res/parking/parking_manager.c PRE-CREATION
/team/group/bridge_construction/res/parking/parking_ui.c PRE-CREATION
/team/group/bridge_construction/res/parking/res_parking.h PRE-CREATION
/team/group/bridge_construction/res/res_parking.c PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/2447/diff/
Testing
-------
This is currently being tested as it's developed and breaks in minor ways frequently. \
Unit tests and testsuite tests are on the to do list.
Thanks,
jrose
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2447/">https://reviewboard.asterisk.org/r/2447/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers, David Lee, kmoore, Matt Jordan, Mark \
Michelson, and rmudgett.</div> <div>By jrose.</div>
<p style="color: grey;"><i>Updated April 30, 2013, 6:44 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Address the last round of review feedback.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21059">ASTERISK-21059</a>, \
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21272">ASTERISK-21272</a>, \
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21353">ASTERISK-21353</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As a result of all the new bridging changes, certain applications such \
as parking, queues, confbridge, and a few others require significant reworking within \
Asterisk to make usable. Parking was less than salvagable, so I've rebuilt it \
from the ground up to use a lot of new stuff including config hooks, the new bridging \
architecture, stasis, and just generally to be an independent module with its own \
scope that doesn't get tangled into a giant morass within features.c
Parking configuration works somewhat differently now and extensions aren't \
necessarily automatically generated (it's optional and hasn't been \
implemented), but the intention with the final result is that if you were using \
parking before without too much additional dialplan manipulation, that should all \
just work once your parking lots are migrated to the new configuration file.
Currently supported:
parking from the PBX with the Park application (all arguments are supported)
parking within a call using the one touch parking feature
parking within a call using DTMF blind transfers (attended transfers work, but \
it's basically just like they called the application itself). Picking up parked \
calls using the PBX Multiple parking lots
All options available to parking lots are currently configurable. Some aren't \
currently doing anything, namely parkext and hints.
To do list:
* Dialplan generation for parking lots with parkext (included 'Park' and \
'ParkedCall' applications)
* Dialplan generation for comebacktoorigin (park-dial extensions)
* Hints
* Implement 'Park' manager action
* Dynamic parking lots and the default parking lot
* Scraping the greasy remnants of parking out of features.c
* CEL events
* Unit tests and testsuite tests</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is currently being tested as it's developed and breaks in minor \
ways frequently. Unit tests and testsuite tests are on the to do list.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/team/group/bridge_construction/include/asterisk/parking.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/team/group/bridge_construction/main/bridging.c <span style="color: \
grey">(387012)</span></li>
<li>/team/group/bridge_construction/main/bridging_roles.c <span style="color: \
grey">(387012)</span></li>
<li>/team/group/bridge_construction/main/config_options.c <span style="color: \
grey">(387012)</span></li>
<li>/team/group/bridge_construction/main/features.c <span style="color: \
grey">(387012)</span></li>
<li>/team/group/bridge_construction/main/parking.c <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/team/group/bridge_construction/res/Makefile <span style="color: \
grey">(387012)</span></li>
<li>/team/group/bridge_construction/res/parking/parking_applications.c <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/team/group/bridge_construction/include/asterisk/config_options.h <span \
style="color: grey">(387012)</span></li>
<li>/team/group/bridge_construction/include/asterisk/bridging.h <span style="color: \
grey">(387012)</span></li>
<li>/team/group/bridge_construction/configs/res_parking.conf.sample <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/team/group/bridge_construction/bridges/bridge_builtin_features.c <span \
style="color: grey">(387012)</span></li>
<li>/team/group/bridge_construction/CHANGES <span style="color: \
grey">(387012)</span></li>
<li>/team/group/bridge_construction/res/parking/parking_bridge.c <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/team/group/bridge_construction/res/parking/parking_bridge_features.c <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/team/group/bridge_construction/res/parking/parking_controller.c <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/team/group/bridge_construction/res/parking/parking_manager.c <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/team/group/bridge_construction/res/parking/parking_ui.c <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/team/group/bridge_construction/res/parking/res_parking.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/team/group/bridge_construction/res/res_parking.c <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2447/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic