[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2466: Pimp my SIP: Call forwarding & diversion headers
From: "Joshua Colp" <reviewboard () asterisk ! org>
Date: 2013-04-30 18:18:24
Message-ID: 20130430181824.3653.75776 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2466/#review8405
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Colp
On April 26, 2013, 6:48 p.m., Kevin Harwell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2466/
> -----------------------------------------------------------
>
> (Updated April 26, 2013, 6:48 p.m.)
>
>
> Review request for Asterisk Developers, Joshua Colp and Mark Michelson.
>
>
> Bugs: ASTERISK-21426
> https://issues.asterisk.org/jira/browse/ASTERISK-21426
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Adds call forwarding support (Josh's patch) to the new SIP work being done in \
> Asterisk. This also includes the ability to add a diversion header to an outgoing \
> response/request when appropriate. The diversion header feature can be turned off \
> by setting the send_diversion=false (defaults to true) on an endpoint within the \
> configuration file.
>
> Diffs
> -----
>
> /team/group/pimp_my_sip/res/res_sip_diversion.c PRE-CREATION
> /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 386621
> /team/group/pimp_my_sip/res/res_sip.c 386621
> /team/group/pimp_my_sip/include/asterisk/res_sip.h 386621
> /team/group/pimp_my_sip/channels/chan_gulp.c 386621
> /team/group/pimp_my_sip/res/res_sip_session.c 386621
>
> Diff: https://reviewboard.asterisk.org/r/2466/diff/
>
>
> Testing
> -------
>
> Wrote a few testsuite tests to make sure calls are being forwarded and the \
> diversion header is added/propagated appropriately.
>
> Thanks,
>
> Kevin Harwell
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2466/">https://reviewboard.asterisk.org/r/2466/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Joshua</p>
<br />
<p>On April 26th, 2013, 6:48 p.m. UTC, Kevin Harwell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers, Joshua Colp and Mark Michelson.</div>
<div>By Kevin Harwell.</div>
<p style="color: grey;"><i>Updated April 26, 2013, 6:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21426">ASTERISK-21426</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Adds call forwarding support (Josh's patch) to the new SIP work \
being done in Asterisk. This also includes the ability to add a diversion header to \
an outgoing response/request when appropriate. The diversion header feature can be \
turned off by setting the send_diversion=false (defaults to true) on an endpoint \
within the configuration file.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Wrote a few testsuite tests to make sure calls are being forwarded and \
the diversion header is added/propagated appropriately.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/team/group/pimp_my_sip/res/res_sip_diversion.c <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip/sip_configuration.c <span style="color: \
grey">(386621)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip.c <span style="color: \
grey">(386621)</span></li>
<li>/team/group/pimp_my_sip/include/asterisk/res_sip.h <span style="color: \
grey">(386621)</span></li>
<li>/team/group/pimp_my_sip/channels/chan_gulp.c <span style="color: \
grey">(386621)</span></li>
<li>/team/group/pimp_my_sip/res/res_sip_session.c <span style="color: \
grey">(386621)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2466/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic