'Re: [asterisk-dev] [Code Review] 2428: Add channel event distribution to app_stasis'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 2428: Add channel event distribution to app_stasis
From:       "opticron" <reviewboard () asterisk ! org>
Date:       2013-04-30 14:03:19
Message-ID: 20130430140319.22015.92374 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2428/
-----------------------------------------------------------

(Updated April 30, 2013, 9:03 a.m.)

Review request for Asterisk Developers.

Changes
-------

Make sure the JSON docs still follow the Swagger API.

Bugs: ASTERISK-21180
    https://issues.asterisk.org/jira/browse/ASTERISK-21180

Repository: Asterisk

Description
-------

Add publication of AMI-equivalent channel event messages to users of app_stasis using JSON blobs.

Diffs (updated)
-----

  trunk/include/asterisk/astobj2.h 386934 
  trunk/include/asterisk/stasis_channels.h 386934 
  trunk/main/astobj2.c 386934 
  trunk/main/manager_channels.c 386934 
  trunk/main/stasis_channels.c 386934 
  trunk/res/res_stasis.c 386934 
  trunk/res/res_stasis_http_events.c 386934 
  trunk/res/res_stasis_websocket.c 386934 
  trunk/res/stasis_http/resource_events.h 386934 
  trunk/res/stasis_http/resource_recordings.h 386934 
  trunk/res/stasis_http/resource_sounds.h 386934 
  trunk/rest-api-templates/asterisk_processor.py 386934 
  trunk/rest-api-templates/event_function_decl.mustache PRE-CREATION 
  trunk/rest-api-templates/res_stasis_http_resource.c.mustache 386934 
  trunk/rest-api-templates/stasis_http_resource.h.mustache 386934 
  trunk/rest-api-templates/swagger_model.py 386934 
  trunk/rest-api/api-docs/events.json 386934 

Diff: https://reviewboard.asterisk.org/r/2428/diff/

Testing
-------

Tested with a hacked together app_stasis app which dumps incoming messages.

Thanks,

opticron

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2428/">https://reviewboard.asterisk.org/r/2428/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>

<p style="color: grey;"><i>Updated April 30, 2013, 9:03 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Make sure the JSON docs still follow the Swagger API.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-21180">ASTERISK-21180</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add publication of AMI-equivalent channel event messages to users of \
app_stasis using JSON blobs.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested with a hacked together app_stasis app which dumps incoming \
messages.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/include/asterisk/astobj2.h <span style="color: grey">(386934)</span></li>

 <li>trunk/include/asterisk/stasis_channels.h <span style="color: \
grey">(386934)</span></li>

 <li>trunk/main/astobj2.c <span style="color: grey">(386934)</span></li>

 <li>trunk/main/manager_channels.c <span style="color: grey">(386934)</span></li>

 <li>trunk/main/stasis_channels.c <span style="color: grey">(386934)</span></li>

 <li>trunk/res/res_stasis.c <span style="color: grey">(386934)</span></li>

 <li>trunk/res/res_stasis_http_events.c <span style="color: \
grey">(386934)</span></li>

 <li>trunk/res/res_stasis_websocket.c <span style="color: grey">(386934)</span></li>

 <li>trunk/res/stasis_http/resource_events.h <span style="color: \
grey">(386934)</span></li>

 <li>trunk/res/stasis_http/resource_recordings.h <span style="color: \
grey">(386934)</span></li>

 <li>trunk/res/stasis_http/resource_sounds.h <span style="color: \
grey">(386934)</span></li>

 <li>trunk/rest-api-templates/asterisk_processor.py <span style="color: \
grey">(386934)</span></li>

 <li>trunk/rest-api-templates/event_function_decl.mustache <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>trunk/rest-api-templates/res_stasis_http_resource.c.mustache <span style="color: \
grey">(386934)</span></li>

 <li>trunk/rest-api-templates/stasis_http_resource.h.mustache <span style="color: \
grey">(386934)</span></li>

 <li>trunk/rest-api-templates/swagger_model.py <span style="color: \
grey">(386934)</span></li>

 <li>trunk/rest-api/api-docs/events.json <span style="color: \
grey">(386934)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2428/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 