'Re: [asterisk-dev] [Code Review] 2480: Properly initiate device state providers'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 2480: Properly initiate device state providers
From:       "Olle E Johansson" <reviewboard () asterisk ! org>
Date:       2013-04-30 5:35:28
Message-ID: 20130430053528.30677.9479 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2480/
-----------------------------------------------------------

(Updated April 30, 2013, 7:35 a.m.)

Status
------

This change has been discarded.

Review request for Asterisk Developers.

Bugs: ASTERISK-17065
    https://issues.asterisk.org/jira/browse/ASTERISK-17065

Repository: Asterisk

Description
-------

When the dialplan loads, all hints are initialized to a first state. If a device \
state provider is not loaded at the time, like meetme (or the new device state \
provider in chan_sip/Pinana), the hints are not initialized to the initial state. \
This affects all hints that have an initial state, like a registration in chan_sip, \
which is a state for "presence" subscriptions using SIMPLE in chan_sip.

The patch in /svn/asterisk/team/oej/pinana-initialize-devstate-trunk fixes this by \
re-initializing all hints using the new device state provider after registration of a \
new device state provider.

Diffs
-----

  /trunk/include/asterisk/pbx.h 386860 
  /trunk/main/devicestate.c 386860 
  /trunk/main/pbx.c 386860 

Diff: https://reviewboard.asterisk.org/r/2480/diff/

Testing
-------

Thanks,

Olle E Johansson

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2480/">https://reviewboard.asterisk.org/r/2480/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray \
solid;">  <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been \
discarded.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Olle E Johansson.</div>

<p style="color: grey;"><i>Updated April 30, 2013, 7:35 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-17065">ASTERISK-17065</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When the dialplan loads, all hints are initialized to a first state. If \
a device state provider is not loaded at the time, like meetme (or the new device \
state provider in chan_sip/Pinana), the hints are not initialized to the initial \
state. This affects all hints that have an initial state, like a registration in \
chan_sip, which is a state for &quot;presence&quot; subscriptions using SIMPLE in \
chan_sip.

The patch in /svn/asterisk/team/oej/pinana-initialize-devstate-trunk fixes this by \
re-initializing all hints using the new device state provider after registration of a \
new device state provider.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/include/asterisk/pbx.h <span style="color: grey">(386860)</span></li>

 <li>/trunk/main/devicestate.c <span style="color: grey">(386860)</span></li>

 <li>/trunk/main/pbx.c <span style="color: grey">(386860)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2480/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 