[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2475: Fix SIP Notify / BLF Stop Working, after packet loss and 10 r
From: "Alec Davis" <reviewboard () asterisk ! org>
Date: 2013-04-27 8:51:44
Message-ID: 20130427085144.19790.68773 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2475/
-----------------------------------------------------------
(Updated April 27, 2013, 8:51 a.m.)
Review request for Asterisk Developers.
Changes
-------
Added further comments in code.
Checked event packages "message-summary" MWI and "call-completion" CC for interlocks, \
they don't appear obvious.
Bugs: ASTERISK-21677
https://issues.asterisk.org/jira/browse/ASTERISK-21677
Repository: Asterisk
Description (updated)
-------
The notify subsystem relies on a NOTIFY 200OK response to clear the \
SIP_PAGE2_STATECHANGEQUEUE flag and p->pendinginvite. If the response never arrives, \
then any further NOTIFYs cannot EVER be sent, they just 'queue' up by replacing the \
previous queued notify.
The fix: Follow RFC6665 4.2.2 more closely, after failed NOTIFY transaction remove \
the subscription. Then after a period of time the client will (re-)subscribe, which \
will create a new subscription.
For minimum BLF 'not working' time maxexpiry in sip.conf needs to be around 300, not \
the default of 3600 seconds.
Diffs (updated)
-----
branches/1.8/channels/chan_sip.c 380212
Diff: https://reviewboard.asterisk.org/r/2475/diff/
Testing (updated)
-------
As per bug report https://issues.asterisk.org/jira/browse/ASTERISK-21677
Asterisk 1.8, subscribers will NOT update their status when they re-subscribe, but \
will on the next event. Asterisk 11, subscribers WILL update their status when they \
re-subscribes.
Thanks,
Alec Davis
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2475/">https://reviewboard.asterisk.org/r/2475/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Alec Davis.</div>
<p style="color: grey;"><i>Updated April 27, 2013, 8:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added further comments in code.
Checked event packages "message-summary" MWI and \
"call-completion" CC for interlocks, they don't appear obvious.</pre> \
</td> </tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-21677">ASTERISK-21677</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The notify subsystem relies on a NOTIFY 200OK response to clear the \
SIP_PAGE2_STATECHANGEQUEUE flag and p->pendinginvite. If the response never \
arrives, then any further NOTIFYs cannot EVER be sent, they just 'queue' up \
by replacing the previous queued notify.
The fix: Follow RFC6665 4.2.2 more closely, after failed NOTIFY transaction remove \
the subscription. Then after a period of time the client will (re-)subscribe, which \
will create a new subscription.
For minimum BLF 'not working' time maxexpiry in sip.conf needs to be around \
300, not the default of 3600 seconds.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">As per bug report \
https://issues.asterisk.org/jira/browse/ASTERISK-21677
Asterisk 1.8, subscribers will NOT update their status when they re-subscribe, but \
will on the next event. Asterisk 11, subscribers WILL update their status when they \
re-subscribes. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>branches/1.8/channels/chan_sip.c <span style="color: grey">(380212)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2475/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic