[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2418: Fix parallel make problems
From: "Shaun Ruffell" <reviewboard () asterisk ! org>
Date: 2013-03-29 14:43:16
Message-ID: 20130329144316.4645.79366 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2418/#review8154
-----------------------------------------------------------
Ship it!
Ship It!
- Shaun Ruffell
On March 28, 2013, 9:48 p.m., David Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2418/
> -----------------------------------------------------------
>
> (Updated March 28, 2013, 9:48 p.m.)
>
>
> Review request for Asterisk Developers and Shaun Ruffell.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> Occasionally, make -j would fail due to missing includes, or other
> unusual errors.
>
> This was due to the 'cleantest' target, which was designed to force a
> make clean when some change in the code would cause the typical
> depedency checking to fail. Several targets in the main Makefile did
> not depend upon cleantest, hence would run in parallel to it. By
> adding the dependency, make -j runs happily now.
>
>
> Diffs
> -----
>
> /branches/1.8/Makefile 384301
>
> Diff: https://reviewboard.asterisk.org/r/2418/diff/
>
>
> Testing
> -------
>
> sruffel ran 13 make -j10 builds which failed consistently before the patch, and worked fine afterwards.
>
>
> Thanks,
>
> David Lee
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2418/">https://reviewboard.asterisk.org/r/2418/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Shaun</p>
<br />
<p>On March 28th, 2013, 9:48 p.m. UTC, David Lee wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers and Shaun Ruffell.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated March 28, 2013, 9:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Occasionally, make -j would fail due to missing includes, or other \
unusual errors.
This was due to the 'cleantest' target, which was designed to force a
make clean when some change in the code would cause the typical
depedency checking to fail. Several targets in the main Makefile did
not depend upon cleantest, hence would run in parallel to it. By
adding the dependency, make -j runs happily now.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">sruffel ran 13 make -j10 builds which failed consistently before the \
patch, and worked fine afterwards.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/Makefile <span style="color: grey">(384301)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2418/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic