'Re: [asterisk-dev] [Code Review] 2393: Add directed pickup to features'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] 2393: Add directed pickup to features
From:       "wedhorn" <reviewboard () asterisk ! org>
Date:       2013-03-28 21:11:09
Message-ID: 20130328211109.14382.35745 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2393/
-----------------------------------------------------------

(Updated March 28, 2013, 9:11 p.m.)

Review request for Asterisk Developers.

Changes
-------

New patch addressing opticrons issues.

I'm not familiar with RAII_VAR, but this seems to work.

Repository: Asterisk

Description
-------

Added ast_pickup_call_directed to features. Included some refactoring of \
ast_pickup_call to reuse same code.

In order to use ast_pickup_call, the chan passed in must have the exten set of the \
intended target. Will only pickup the target if the exten's match and the \
pickupgroupdirected and callgroupdirected of the chans match.

Also add ast_channel_callgroupdirected and ast_channel_pickupgroupdirected functions \
(and set functions) including code to set both of these in skinny and sip.

Code to actually do a directed pickup included in skinny.

Diffs (updated)
-----

  /trunk/CHANGES 383948 
  /trunk/channels/chan_sip.c 383948 
  /trunk/channels/chan_skinny.c 383948 
  /trunk/channels/sip/include/sip.h 383948 
  /trunk/configs/sip.conf.sample 383948 
  /trunk/configs/skinny.conf.sample 383948 
  /trunk/include/asterisk/channel.h 383948 
  /trunk/include/asterisk/features.h 383948 
  /trunk/main/channel_internal_api.c 383948 
  /trunk/main/features.c 383948 

Diff: https://reviewboard.asterisk.org/r/2393/diff/

Testing
-------

Directed pickup to non ringing skinny and non ringing sip device (with matching and \
unset groups). Returns without picking up.

Directed pickup to ringing skinny and ringing sip device, with matching groups, picks \
up call, with unmatching groups return without pickup.

Thanks,

wedhorn

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2393/">https://reviewboard.asterisk.org/r/2393/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By wedhorn.</div>

<p style="color: grey;"><i>Updated March 28, 2013, 9:11 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">New patch addressing opticrons issues.

I&#39;m not familiar with RAII_VAR, but this seems to work.</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Added ast_pickup_call_directed to features. Included some refactoring of \
ast_pickup_call to reuse same code.

In order to use ast_pickup_call, the chan passed in must have the exten set of the \
intended target. Will only pickup the target if the exten&#39;s match and the \
pickupgroupdirected and callgroupdirected of the chans match.

Also add ast_channel_callgroupdirected and ast_channel_pickupgroupdirected functions \
(and set functions) including code to set both of these in skinny and sip.

Code to actually do a directed pickup included in skinny.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Directed pickup to non ringing skinny and non ringing sip device (with \
matching and unset groups). Returns without picking up.

Directed pickup to ringing skinny and ringing sip device, with matching groups, picks \
up call, with unmatching groups return without pickup.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/CHANGES <span style="color: grey">(383948)</span></li>

 <li>/trunk/channels/chan_sip.c <span style="color: grey">(383948)</span></li>

 <li>/trunk/channels/chan_skinny.c <span style="color: grey">(383948)</span></li>

 <li>/trunk/channels/sip/include/sip.h <span style="color: grey">(383948)</span></li>

 <li>/trunk/configs/sip.conf.sample <span style="color: grey">(383948)</span></li>

 <li>/trunk/configs/skinny.conf.sample <span style="color: grey">(383948)</span></li>

 <li>/trunk/include/asterisk/channel.h <span style="color: grey">(383948)</span></li>

 <li>/trunk/include/asterisk/features.h <span style="color: \
grey">(383948)</span></li>

 <li>/trunk/main/channel_internal_api.c <span style="color: \
grey">(383948)</span></li>

 <li>/trunk/main/features.c <span style="color: grey">(383948)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2393/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 