[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] 2414: install_prereq: Build jansson from source, when necessary
From: "Shaun Ruffell" <reviewboard () asterisk ! org>
Date: 2013-03-26 18:44:59
Message-ID: 20130326184459.30010.53018 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2414/#review8141
-----------------------------------------------------------
Ship it!
Ship It!
- Shaun Ruffell
On March 26, 2013, 6:21 p.m., David Lee wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2414/
> -----------------------------------------------------------
>
> (Updated March 26, 2013, 6:21 p.m.)
>
>
> Review request for Asterisk Developers, Jason Parker and Matt Jordan.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> When r383579 was committed, it made Jansson a required dependency.
>
> While libjansson-dev and jansson-devel are available on recent
> distros, some older (but still supported) distros don't have
> it. There's a pull request[1] to get it into repoforge, but that still
> doesn't help everyone. (And helps no one until the pull request is
> merged and packages are built).
>
> This patch adds Jansson install from source to the install_unpackaged()
> function. There are a few gotcha's, which makes this change not
> completely trivial.
>
> * Since Jansson may be installed by a package, don't install from
> source if a package installation can be found
> * libresample may also be installed via package, so I added a
> similar check to that.
> * Since Jansson installs into /usr/local, this patch also adds
> /usr/local/lib to /etc/ld.so.conf.d so that the library can be
> found.
> * The alternative was to install into /usr, but then it gets
> complicated having to deal with EL's /usr/lib{32,64} shenanigans.
>
> [1]: https://github.com/repoforge/rpms/pull/250
>
>
> Diffs
> -----
>
> /trunk/contrib/scripts/install_prereq 383913
>
> Diff: https://reviewboard.asterisk.org/r/2414/diff/
>
>
> Testing
> -------
>
> Ran script on CentOS 5 and 6; it seemed to do the right thing.
>
>
> Thanks,
>
> David Lee
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2414/">https://reviewboard.asterisk.org/r/2414/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- Shaun</p>
<br />
<p>On March 26th, 2013, 6:21 p.m. UTC, David Lee wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers, Jason Parker and Matt Jordan.</div>
<div>By David Lee.</div>
<p style="color: grey;"><i>Updated March 26, 2013, 6:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When r383579 was committed, it made Jansson a required dependency.
While libjansson-dev and jansson-devel are available on recent
distros, some older (but still supported) distros don't have
it. There's a pull request[1] to get it into repoforge, but that still
doesn't help everyone. (And helps no one until the pull request is
merged and packages are built).
This patch adds Jansson install from source to the install_unpackaged()
function. There are a few gotcha's, which makes this change not
completely trivial.
* Since Jansson may be installed by a package, don't install from
source if a package installation can be found
* libresample may also be installed via package, so I added a
similar check to that.
* Since Jansson installs into /usr/local, this patch also adds
/usr/local/lib to /etc/ld.so.conf.d so that the library can be
found.
* The alternative was to install into /usr, but then it gets
complicated having to deal with EL's /usr/lib{32,64} shenanigans.
[1]: https://github.com/repoforge/rpms/pull/250
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran script on CentOS 5 and 6; it seemed to do the right thing.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/contrib/scripts/install_prereq <span style="color: \
grey">(383913)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2414/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic