[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review]: Add Path header support to chan_sip
From: "Olle E Johansson" <reviewboard () asterisk ! org>
Date: 2013-02-28 16:38:13
Message-ID: 20130228163813.9839.12821 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 24, 2013, 7:20 p.m., Matt Jordan wrote:
> > This feels very ready :-)
> =
> Matt Jordan wrote:
> Olle - want me to do the commit honors, or would you like to?
Feel free to go ahead! Thank you for the cooperation.
- Olle E
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2235/#review7930
-----------------------------------------------------------
On Feb. 24, 2013, 3:48 a.m., Olle E Johansson wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2235/
> -----------------------------------------------------------
> =
> (Updated Feb. 24, 2013, 3:48 a.m.)
> =
> =
> Review request for Asterisk Developers and Klaus Darilion.
> =
> =
> Summary
> -------
> =
> This is continued development based on https://reviewboard.asterisk.org/r=
/991/ by Klaus Darillion
> =
> In that review Klaus wrote:
> "This patch adds support for the Parse header (RFC 3327). This allows to =
record the Path (route) of incoming REGISTER requests and then reuse the le=
arned path on outgoing out-of-dialog requests as a pre-loaded route set.
> =
> I tried to reuse as much of existing code as possible. There are several =
parts where I am not sure if it is implemented nice and follow chan_sip des=
ign rules (are there any?) I will post my questions as a review to myself."
> =
> ---
> I have added realtime support and the global flags, as well as some other=
minor fixes. The bulk of this code is still Klaus' work.
> =
> =
> This addresses bug ASTERISK-16884.
> https://issues.asterisk.org/jira/browse/ASTERISK-16884
> =
> =
> Diffs
> -----
> =
> /trunk/CHANGES 381912 =
> /trunk/CREDITS 381912 =
> /trunk/channels/chan_sip.c 381912 =
> /trunk/channels/sip/include/sip.h 381912 =
> /trunk/configs/res_ldap.conf.sample 381912 =
> /trunk/configs/sip.conf.sample 381912 =
> /trunk/contrib/realtime/mysql/sippeers.sql 381912 =
> /trunk/contrib/realtime/postgresql/realtime.sql 381912 =
> /trunk/contrib/scripts/asterisk.ldap-schema 381912 =
> /trunk/contrib/scripts/asterisk.ldif 381912 =
> =
> Diff: https://reviewboard.asterisk.org/r/2235/diff
> =
> =
> Testing
> -------
> =
> I have this patch running with and without NAT, but not with realtime. Wi=
ll test, but have also asked for testers on asterisk-dev. Need help with th=
e LDAP schemas.
> =
> =
> Thanks,
> =
> Olle E
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2235/">https://reviewboard.asterisk.org/r/2235/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 24th, 2013, 7:20 p.m., <b>Matt \
Jordan</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This feels very ready :-)</pre> </blockquote>
<p>On February 28th, 2013, 10:35 a.m., <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Olle - want me to do the \
commit honors, or would you like to?</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Feel free to go ahead! \
Thank you for the cooperation.</pre> <br />
<p>- Olle E</p>
<br />
<p>On February 24th, 2013, 3:48 a.m., Olle E Johansson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers and Klaus Darilion.</div>
<div>By Olle E Johansson.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2013, 3:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is continued development based on \
https://reviewboard.asterisk.org/r/991/ by Klaus Darillion
In that review Klaus wrote:
"This patch adds support for the Parse header (RFC 3327). This allows to record \
the Path (route) of incoming REGISTER requests and then reuse the learned path on \
outgoing out-of-dialog requests as a pre-loaded route set.
I tried to reuse as much of existing code as possible. There are several parts where \
I am not sure if it is implemented nice and follow chan_sip design rules (are there \
any?) I will post my questions as a review to myself."
---
I have added realtime support and the global flags, as well as some other minor \
fixes. The bulk of this code is still Klaus' work. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have this patch running with and without NAT, but not with realtime. \
Will test, but have also asked for testers on asterisk-dev. Need help with the LDAP \
schemas.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-16884">ASTERISK-16884</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/CHANGES <span style="color: grey">(381912)</span></li>
<li>/trunk/CREDITS <span style="color: grey">(381912)</span></li>
<li>/trunk/channels/chan_sip.c <span style="color: grey">(381912)</span></li>
<li>/trunk/channels/sip/include/sip.h <span style="color: grey">(381912)</span></li>
<li>/trunk/configs/res_ldap.conf.sample <span style="color: \
grey">(381912)</span></li>
<li>/trunk/configs/sip.conf.sample <span style="color: grey">(381912)</span></li>
<li>/trunk/contrib/realtime/mysql/sippeers.sql <span style="color: \
grey">(381912)</span></li>
<li>/trunk/contrib/realtime/postgresql/realtime.sql <span style="color: \
grey">(381912)</span></li>
<li>/trunk/contrib/scripts/asterisk.ldap-schema <span style="color: \
grey">(381912)</span></li>
<li>/trunk/contrib/scripts/asterisk.ldif <span style="color: \
grey">(381912)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2235/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic