[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Disallow MoH upon hold option
From:       "Mark Michelson" <reviewboard () asterisk ! org>
Date:       2013-02-25 21:58:24
Message-ID: 20130225215824.1506.89242 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2336/#review7943
-----------------------------------------------------------

Ship it!


Looks good by me. Just address Josh's comment.

- Mark


On Feb. 19, 2013, 3:26 p.m., Kevin Harwell wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2336/
> -----------------------------------------------------------
> =

> (Updated Feb. 19, 2013, 3:26 p.m.)
> =

> =

> Review request for Asterisk Developers.
> =

> =

> Summary
> -------
> =

> A remote hold via SIP causes local music on hold.  Added a per peer optio=
n "discard_remote_hold_retrieval" (default "no") that if set will not trigg=
er the music on hold event.
> =

> =

> This addresses bug ABE-2899.
>     https://issues.asterisk.org/jira/browse/ABE-2899
> =

> =

> Diffs
> -----
> =

>   /trunk/CHANGES 381793 =

>   /trunk/channels/chan_sip.c 381793 =

>   /trunk/channels/sip/include/sip.h 381793 =

> =

> Diff: https://reviewboard.asterisk.org/r/2336/diff
> =

> =

> Testing
> -------
> =

> Set the discard_remote_hold_retrieval option for phone A, called phone B,=
 and then had phone A place phone B on hold.  No music on hold was played. =
 Also wrote a test for the teststuite that runs through several scenarios a=
nd makes sure that no music on hold event is raised.
> =

> =

> Thanks,
> =

> Kevin
> =

>


[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2336/">https://reviewboard.asterisk.org/r/2336/</a>
  </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>



 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good by me. Just \
address Josh&#39;s comment.</pre>  <br />







<p>- Mark</p>


<br />
<p>On February 19th, 2013, 3:26 p.m., Kevin Harwell wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Kevin Harwell.</div>


<p style="color: grey;"><i>Updated Feb. 19, 2013, 3:26 p.m.</i></p>




<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">A remote hold via SIP causes local music on hold.  Added a per peer \
option &quot;discard_remote_hold_retrieval&quot; (default &quot;no&quot;) that if set \
will not trigger the music on hold event.</pre>  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Set the discard_remote_hold_retrieval option for phone A, called phone \
B, and then had phone A place phone B on hold.  No music on hold was played.  Also \
wrote a test for the teststuite that runs through several scenarios and makes sure \
that no music on hold event is raised.</pre>  </td>
 </tr>
</table>



<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>


 <a href="https://issues.asterisk.org/jira/browse/ABE-2899">ABE-2899</a>


</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/trunk/CHANGES <span style="color: grey">(381793)</span></li>

 <li>/trunk/channels/chan_sip.c <span style="color: grey">(381793)</span></li>

 <li>/trunk/channels/sip/include/sip.h <span style="color: grey">(381793)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2336/diff/" style="margin-left: \
3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>



--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic