[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] Restore default_user and default_bridge profiles in ConfBridge when
From: "Mark Michelson" <reviewboard () asterisk ! org>
Date: 2013-02-25 16:46:27
Message-ID: 20130225164627.19066.47161 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2356/#review7933
-----------------------------------------------------------
Ship it!
The only things I can think of that would be good to add are documentation-=
related. It should be clear that even if there is no default user or bridge=
profile specified in the configuration that it exists internally. I also s=
uggest issuing a NOTICE-level message if you have to generate a default use=
r or bridge profile. Otherwise, If someone were to delete the default user =
profile, for example, it might seem a bit strange that if they issue a "con=
fbridge show profile users" they'll still see the default listed.
- Mark
On Feb. 25, 2013, 10:16 a.m., Matt Jordan wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2356/
> -----------------------------------------------------------
> =
> (Updated Feb. 25, 2013, 10:16 a.m.)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> The confbridge sample configuration file has the following to say about t=
he default user/bridge profiles:
> =
> ; --- Default Information ---
> ; The default_user and default_bridge sections are applied
> ; automatically to all ConfBridge instances invoked without
> ; a user, or bridge argument. No menu is applied by default.
> ;
> =
> These always have to exist: while they can be specified in the conf file =
and their default values overriden, removing them from the conf file should=
not remove them from ConfBridge - it has to have a default profile to appl=
y to bridges/users, otherwise it doesn't know what to do with them when you=
fail to specify a profile. What's more, applications such as Page (which u=
se ConfBridge under the hood) have no mechanism to supply a bridge profile =
to build on, resulting in errors.
> =
> This patch restores the behavior prior to the configuration re-work that =
went in for ConfBridge for Asterisk 11. It ensures that if the conf file pr=
ocessed does not provide a default bridge/user profile, that the objects ar=
e created and populated with their default values appropriately.
> =
> =
> Diffs
> -----
> =
> /branches/11/apps/confbridge/conf_config_parser.c 382055 =
> =
> Diff: https://reviewboard.asterisk.org/r/2356/diff
> =
> =
> Testing
> -------
> =
> Removed the default_bridge/default_user profiles from the configuration f=
ile. Started Asterisk, CLI command successfully showed that the default pro=
files existed in memory with the appropriate values.
> =
> =
> Thanks,
> =
> Matt
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2356/">https://reviewboard.asterisk.org/r/2356/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The only things I can \
think of that would be good to add are documentation-related. It should be clear that \
even if there is no default user or bridge profile specified in the configuration \
that it exists internally. I also suggest issuing a NOTICE-level message if you have \
to generate a default user or bridge profile. Otherwise, If someone were to delete \
the default user profile, for example, it might seem a bit strange that if they issue \
a "confbridge show profile users" they'll still see the default \
listed.</pre> <br />
<p>- Mark</p>
<br />
<p>On February 25th, 2013, 10:16 a.m., Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated Feb. 25, 2013, 10:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The confbridge sample configuration file has the following to say about \
the default user/bridge profiles:
; --- Default Information ---
; The default_user and default_bridge sections are applied
; automatically to all ConfBridge instances invoked without
; a user, or bridge argument. No menu is applied by default.
;
These always have to exist: while they can be specified in the conf file and their \
default values overriden, removing them from the conf file should not remove them \
from ConfBridge - it has to have a default profile to apply to bridges/users, \
otherwise it doesn't know what to do with them when you fail to specify a \
profile. What's more, applications such as Page (which use ConfBridge under the \
hood) have no mechanism to supply a bridge profile to build on, resulting in errors.
This patch restores the behavior prior to the configuration re-work that went in for \
ConfBridge for Asterisk 11. It ensures that if the conf file processed does not \
provide a default bridge/user profile, that the objects are created and populated \
with their default values appropriately.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removed the default_bridge/default_user profiles from the configuration \
file. Started Asterisk, CLI command successfully showed that the default profiles \
existed in memory with the appropriate values.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/apps/confbridge/conf_config_parser.c <span style="color: \
grey">(382055)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2356/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic