[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] bridging tests: call parking timeout (comebacktoorigin = yes)
From: "jrose" <reviewboard () asterisk ! org>
Date: 2013-01-31 19:16:48
Message-ID: 20130131191648.7516.9452 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2306/
-----------------------------------------------------------
(Updated Jan. 31, 2013, 1:16 p.m.)
Review request for Asterisk Developers, Mark Michelson and kmoore.
Changes
-------
Removing files that I added to ast2's configs in error.
Summary
-------
Three calls tested against a comebacktoorigin = yes parkinglot.
The first test calls and when it times out it calls back and gets answered then \
hungup. The second test calls and when it times out, it calls back and is left \
waiting for the dial timeout to occur The third test calls and when it times out, it \
calls back and gets a busy signal.
In each case, the disposition of the call is evaluated as well as how it continues in \
the dialplan. This test uses the failtoken concept that I introduced the other day as \
well.
Diffs (updated)
-----
/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/Executioner.py \
PRE-CREATION /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/configs/ast1/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/configs/ast1/features.conf \
PRE-CREATION /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/configs/ast2/extensions.conf \
PRE-CREATION /asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/test-config.yaml \
PRE-CREATION /asterisk/trunk/tests/bridge/parkcall_timeout/tests.yaml PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/2306/diff
Testing
-------
Tested changes to expectations, changes to the dial plan, and changes the CDR test \
module to see how they would impact failures. In every case, things went as I \
anticipated. We do need to update some documentation in features.conf.sample since it \
suggests that when the dial times out that the dial plan will advance to the 't' \
extension and this doesn't happen (and as far as I'm aware never happened).
Thanks,
jrose
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2306/">https://reviewboard.asterisk.org/r/2306/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers, Mark Michelson and kmoore.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated Jan. 31, 2013, 1:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removing files that I added to ast2's configs in error.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Three calls tested against a comebacktoorigin = yes parkinglot. The \
first test calls and when it times out it calls back and gets answered then hungup. \
The second test calls and when it times out, it calls back and is left waiting for \
the dial timeout to occur The third test calls and when it times out, it calls back \
and gets a busy signal.
In each case, the disposition of the call is evaluated as well as how it continues in \
the dialplan. This test uses the failtoken concept that I introduced the other day as \
well.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested changes to expectations, changes to the dial plan, and changes \
the CDR test module to see how they would impact failures. In every case, things \
went as I anticipated. We do need to update some documentation in \
features.conf.sample since it suggests that when the dial times out that the dial \
plan will advance to the 't' extension and this doesn't happen (and as \
far as I'm aware never happened).</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/Executioner.py \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/configs/ast1/features.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/configs/ast2/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/comebacktoorigin_yes/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/bridge/parkcall_timeout/tests.yaml <span style="color: \
grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2306/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic