[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] Correct the number of available call numbers in IAX2
From: "rmudgett" <reviewboard () asterisk ! org>
Date: 2013-01-28 20:10:28
Message-ID: 20130128201028.2629.16482 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2293/#review7761
-----------------------------------------------------------
Ship it!
This looks OK now. Just a minor comment correction.
/trunk/channels/iax2.h
<https://reviewboard.asterisk.org/r/2293/#comment14750>
This statement is not quite true. How about this instead:
=
For LOW_MEMORY, we use 2049 for compatibility with earlier code because=
callno 2048 leaked out when the intended callno range was 2-2047.
- rmudgett
On Jan. 28, 2013, 1:57 p.m., Sean Bright wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2293/
> -----------------------------------------------------------
> =
> (Updated Jan. 28, 2013, 1:57 p.m.)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> While populating the list of available call numbers in IAX2 when LOW_MEMO=
RY is not defined, we use every number between 2 and 32768 (inclusive). 32=
768 is a 16 bit number (a 1 followed by 15 0s). According to the IAX2 RFC,=
call numbers are 15 bit values, making 32768 invalid.
> =
> This patch reduces the number of allocated call numbers by 1 so that the =
are all 15 bits.
> =
> I intend to commit this change to Asterisk versions 1.8, 11, and trunk.
> =
> I have another patch to replace the ao2_container usage for call number s=
election almost ready for RB as well.
> =
> =
> Diffs
> -----
> =
> /trunk/channels/chan_iax2.c 380249 =
> /trunk/channels/iax2.h 380249 =
> =
> Diff: https://reviewboard.asterisk.org/r/2293/diff
> =
> =
> Testing
> -------
> =
> Ran thousands of test calls (both trunked and non-trunked) between 3 Aste=
risk servers.
> =
> =
> Thanks,
> =
> Sean
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2293/">https://reviewboard.asterisk.org/r/2293/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks OK now. Just \
a minor comment correction.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2293/diff/4/?file=33121#file33121line32" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/channels/iax2.h</a> <span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">32</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * We use 2049 for the LOW_MEMORY case because 2048 is a valid call \
number</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">33</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * allowed by the protocol, whereas 32768 is not.</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This \
statement is not quite true. How about this instead:
For LOW_MEMORY, we use 2049 for compatibility with earlier code because callno 2048 \
leaked out when the intended callno range was 2-2047.</pre> </div>
<br />
<p>- rmudgett</p>
<br />
<p>On January 28th, 2013, 1:57 p.m., Sean Bright wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Sean Bright.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2013, 1:57 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While populating the list of available call numbers in IAX2 when \
LOW_MEMORY is not defined, we use every number between 2 and 32768 (inclusive). \
32768 is a 16 bit number (a 1 followed by 15 0s). According to the IAX2 RFC, call \
numbers are 15 bit values, making 32768 invalid.
This patch reduces the number of allocated call numbers by 1 so that the are all 15 \
bits.
I intend to commit this change to Asterisk versions 1.8, 11, and trunk.
I have another patch to replace the ao2_container usage for call number selection \
almost ready for RB as well.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran thousands of test calls (both trunked and non-trunked) between 3 \
Asterisk servers.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(380249)</span></li>
<li>/trunk/channels/iax2.h <span style="color: grey">(380249)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2293/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic