[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] Bug in asterisk/strings.h include file	(Asterisk 11)
From:       Pavel Troller <patrol () sinus ! cz>
Date:       2013-01-02 16:18:38
Message-ID: 20130102161838.GA1408 () tangens ! sinus ! cz
[Download RAW message or body]

> On 13-01-02 12:29 AM, Pavel Troller wrote:
>> Hi!
>>    During compilation of a third-party module, I noticed a warning about
>> "struct ast_str declared inside parameter list", generated during processing
>> of asterisk/strings.h. It seems that compiler is right, because the prototype
>> of ast_regex_string_to_regex_pattern() function on line 268 contains
>> "struct ast_str **regex_pattern" parameter, but struct ast_str is declared
>> later, on line 379.
>>    I've solved the problem by moving the prototype to the very end of the
>> file in my local installed copy of asterisk/strings.h. Maybe a better
>> rearrangement is possible, like moving structure declarations above the
>> prototype section, which is a common practice in include files, but I don't
>> want to judge it, I'm just reporting this little problem.
>>    With regards,
>>      Pavel Troller
>>
> Might be worth opening an issue in JIRA and attaching a patch if you would 
> like it fixed. Seems reasonable.
>
> -- 
> Paul Belanger | PolyBeacon, Inc.

Hi Paul,
  thanks for your opinion. Issue created, patch attached.
  With regards,
    Pavel

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]