'[asterisk-dev] [Code Review] Change dynamic features buffer to use ast_str instead of a fixed sized'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    [asterisk-dev] [Code Review] Change dynamic features buffer to use ast_str instead of a fixed sized
From:       "elguero" <reviewboard () asterisk ! org>
Date:       2012-11-30 15:16:22
Message-ID: 20121130151622.23103.68686 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2221/
-----------------------------------------------------------

Review request for Asterisk Developers.

Summary
-------

Currently, the buffer for the dynamic features list is being set to a fixed=
 size of 128.  If the list is bigger than that, it obviously results in the=
 dynamic feature not working.

This patch attempts to change the buffer from a fixed size to a dynamic one.

Is this a candidate for all branches?

This addresses bug ASTERISK-20680.
    https://issues.asterisk.org/jira/browse/ASTERISK-20680

Diffs
-----

  /branches/11/main/features.c 376416 =

Diff: https://reviewboard.asterisk.org/r/2221/diff

Testing
-------

Local dev box.  I was waiting for the reporter to test it as well but I hav=
en't heard back yet.

Thanks,

elguero

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2221/">https://reviewboard.asterisk.org/r/2221/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By elguero.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Currently, the buffer for the dynamic features list is being set to a \
fixed size of 128.  If the list is bigger than that, it obviously results in the \
dynamic feature not working.

This patch attempts to change the buffer from a fixed size to a dynamic one.

Is this a candidate for all branches?</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Local dev box.  I was waiting for the reporter to test it as well but I \
haven&#39;t heard back yet.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-20680">ASTERISK-20680</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/11/main/features.c <span style="color: grey">(376416)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2221/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 