[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] Add UUID support to Asterisk
From: "David Lee" <reviewboard () asterisk ! org>
Date: 2012-11-29 19:24:18
Message-ID: 20121129192418.22834.23846 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2217/#review7469
-----------------------------------------------------------
Ship it!
Minor nits, otherwise it's good. Whether you decide to keep the compile tim=
e test or switch it to a runtime test, I'm good with the patch.
/trunk/main/uuid.c
<https://reviewboard.asterisk.org/r/2217/#comment14269>
Begone, extra tab!
/trunk/main/uuid.c
<https://reviewboard.asterisk.org/r/2217/#comment14268>
The test in libuuid is a runtime test instead of a compile time test. I=
don't know if that's an important difference, but that is a difference.
/trunk/main/uuid.c
<https://reviewboard.asterisk.org/r/2217/#comment14267>
The use of the lock ensures correctness for UUID generation. Other uses=
of rand() in the system may return the same number that's used in creating=
a UUID, but that shouldn't matter for UUID generation.
- David
On Nov. 29, 2012, 12:30 p.m., Mark Michelson wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2217/
> -----------------------------------------------------------
> =
> (Updated Nov. 29, 2012, 12:30 p.m.)
> =
> =
> Review request for Asterisk Developers, Matt Jordan and David Lee.
> =
> =
> Summary
> -------
> =
> This is the first of many parts of the overall goal of improving Asterisk=
APIs. This adds a UUID API to Asterisk, eventually to be used as a method =
of uniquely identifying channels and potentially other objects.
> =
> The implementation here uses libuuid, which is packaged by all major Linu=
x distributions. The API is basically a wrapper around libuuid's API, but i=
t hides all implementation details in case we want to switch out libraries =
at some point.
> =
> Licensing for libuuid is a bit confusing. On one hand, this online man pa=
ge (http://linux.die.net/man/3/libuuid) claims that the library is distribu=
ted under the LGPL version 2. However, when I downloaded the source for the=
library on my machine, the code had the 3-clause BSD license printed in th=
e source. In either case, I believe use of external library is license-comp=
atible with Asterisk.
> =
> Regarding specific implementation decisions, I think comments in the code=
should explain why I chose to do things certain ways. Please let me know i=
f anything should be done differently or if you have ideas for tests beyond=
what I have already included.
> =
> I have no idea what is up with the changes listed in autoconfig.h.in. Tho=
se changes showed up when I ran the bootstrap.sh script after changing conf=
igure.ac. =
> =
> =
> This addresses bug ASTERISK-20725.
> https://issues.asterisk.org/jira/browse/ASTERISK-20725
> =
> =
> Diffs
> -----
> =
> /trunk/configure UNKNOWN =
> /trunk/configure.ac 376832 =
> /trunk/include/asterisk/autoconfig.h.in 376832 =
> /trunk/include/asterisk/uuid.h PRE-CREATION =
> /trunk/main/Makefile 376832 =
> /trunk/main/asterisk.c 376832 =
> /trunk/main/uuid.c PRE-CREATION =
> /trunk/tests/test_uuid.c PRE-CREATION =
> =
> Diff: https://reviewboard.asterisk.org/r/2217/diff
> =
> =
> Testing
> -------
> =
> I have included a set of unit tests that exercise all the APIs. They pass=
when run locally.
> =
> =
> Thanks,
> =
> Mark
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2217/">https://reviewboard.asterisk.org/r/2217/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Minor nits, otherwise \
it's good. Whether you decide to keep the compile time test or switch it to a \
runtime test, I'm good with the patch.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2217/diff/3-4/?file=32269#file32269line103" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/main/uuid.c</a> <span style="font-weight: normal;">
(Diff revisions 3 - 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">struct \
ast_uuid {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">103</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew"> </span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Begone, \
extra tab!</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2217/diff/3-4/?file=32269#file32269line186" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/main/uuid.c</a> <span style="font-weight: normal;">
(Diff revisions 3 - 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ast_uuid_init(void)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">186</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cp">#ifndef HAVE_DEV_URANDOM</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The test in \
libuuid is a runtime test instead of a compile time test. I don't know if \
that's an important difference, but that is a difference.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2217/diff/3-4/?file=32269#file32269line193" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/main/uuid.c</a> <span style="font-weight: normal;">
(Diff revisions 3 - 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
ast_uuid_init(void)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">193</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">" 2. Random number generation is not guaranteed to be as random, \
meaning there is</span><span class="se">\n</span><span \
class="s">"</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">194</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">" a very remote chance you may see duplicate UUIDs.</span><span \
class="se">\n</span><span class="s">"</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The use of \
the lock ensures correctness for UUID generation. Other uses of rand() in the system \
may return the same number that's used in creating a UUID, but that shouldn't \
matter for UUID generation.</pre> </div>
<br />
<p>- David</p>
<br />
<p>On November 29th, 2012, 12:30 p.m., Mark Michelson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers, Matt Jordan and David Lee.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2012, 12:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is the first of many parts of the overall goal of improving \
Asterisk APIs. This adds a UUID API to Asterisk, eventually to be used as a method of \
uniquely identifying channels and potentially other objects.
The implementation here uses libuuid, which is packaged by all major Linux \
distributions. The API is basically a wrapper around libuuid's API, but it hides \
all implementation details in case we want to switch out libraries at some point.
Licensing for libuuid is a bit confusing. On one hand, this online man page \
(http://linux.die.net/man/3/libuuid) claims that the library is distributed under the \
LGPL version 2. However, when I downloaded the source for the library on my machine, \
the code had the 3-clause BSD license printed in the source. In either case, I \
believe use of external library is license-compatible with Asterisk.
Regarding specific implementation decisions, I think comments in the code should \
explain why I chose to do things certain ways. Please let me know if anything should \
be done differently or if you have ideas for tests beyond what I have already \
included.
I have no idea what is up with the changes listed in autoconfig.h.in. Those changes \
showed up when I ran the bootstrap.sh script after changing configure.ac. </pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have included a set of unit tests that exercise all the APIs. They \
pass when run locally.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-20725">ASTERISK-20725</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/configure <span style="color: grey">(UNKNOWN)</span></li>
<li>/trunk/configure.ac <span style="color: grey">(376832)</span></li>
<li>/trunk/include/asterisk/autoconfig.h.in <span style="color: \
grey">(376832)</span></li>
<li>/trunk/include/asterisk/uuid.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/main/Makefile <span style="color: grey">(376832)</span></li>
<li>/trunk/main/asterisk.c <span style="color: grey">(376832)</span></li>
<li>/trunk/main/uuid.c <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/tests/test_uuid.c <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2217/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic