[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review]: Add test for generation of 422 responses with session timers
From: "opticron" <reviewboard () asterisk ! org>
Date: 2012-11-29 16:31:27
Message-ID: 20121129163127.4832.92470 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 28, 2012, 2:15 p.m., Mark Michelson wrote:
> > I suggest adding a second scenario where a Min-SE is specified in the config. \
> > That way we can also verify with this test that the Min-SE setting is being read \
> > and honored.
Done.
> On Nov. 28, 2012, 2:15 p.m., Mark Michelson wrote:
> > asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/configs/ast1/sip.conf, \
> > line 2 <https://reviewboard.asterisk.org/r/2218/diff/2/?file=32259#file32259line2>
> >
> > Avoid using deprecated option names in tests. Use "directmedia=no" instead.
Removed since it was unnecessary.
- opticron
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2218/#review7462
-----------------------------------------------------------
On Nov. 28, 2012, 10:42 a.m., opticron wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2218/
> -----------------------------------------------------------
>
> (Updated Nov. 28, 2012, 10:42 a.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> This test ensures that Asterisk will generate a 422 response if an INVITE comes in \
> with a Session-Expires below the local Min-SE.
>
> This addresses bug SWP-5056.
> https://issues.asterisk.org/jira/browse/SWP-5056
>
>
> Diffs
> -----
>
> asterisk/trunk/tests/channels/SIP/session_timers/tests.yaml 3547
> asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/configs/ast1/extensions.conf \
> PRE-CREATION asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/configs/ast1/sip.conf \
> PRE-CREATION asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/sipp/uac-no-hangup.xml \
> PRE-CREATION asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/test-config.yaml \
> PRE-CREATION
> Diff: https://reviewboard.asterisk.org/r/2218/diff
>
>
> Testing
> -------
>
> Ran the test and it worked as expected.
>
>
> Thanks,
>
> opticron
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2218/">https://reviewboard.asterisk.org/r/2218/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 28th, 2012, 2:15 p.m., <b>Mark \
Michelson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I suggest adding a second scenario where a Min-SE is specified in the \
config. That way we can also verify with this test that the Min-SE setting is being \
read and honored.</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done.</pre> <br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 28th, 2012, 2:15 p.m., <b>Mark \
Michelson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2218/diff/2/?file=32259#file32259line2" \
style="color: black; font-weight: bold; text-decoration: \
underline;">asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/configs/ast1/sip.conf</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">canreinvite=no</pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Avoid using deprecated \
option names in tests. Use "directmedia=no" instead.</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed \
since it was unnecessary.</pre> <br />
<p>- opticron</p>
<br />
<p>On November 28th, 2012, 10:42 a.m., opticron wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated Nov. 28, 2012, 10:42 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This test ensures that Asterisk will generate a 422 response if an \
INVITE comes in with a Session-Expires below the local Min-SE.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran the test and it worked as expected.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/SWP-5056">SWP-5056</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>asterisk/trunk/tests/channels/SIP/session_timers/tests.yaml <span style="color: \
grey">(3547)</span></li>
<li>asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/configs/ast1/sip.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/sipp/uac-no-hangup.xml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>asterisk/trunk/tests/channels/SIP/session_timers/uas_minimum_se/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2218/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic