'Re: [asterisk-dev] [Code Review] Fix natdetected flag being set when VIA doesn't include port in add'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Fix natdetected flag being set when VIA doesn't include port in add
From:       "wdoekes" <reviewboard () asterisk ! org>
Date:       2012-11-28 8:37:16
Message-ID: 20121128083716.804.89628 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2206/#review7458
-----------------------------------------------------------

Ship it!

Looks good to go.

- wdoekes

On Nov. 27, 2012, 10:12 a.m., elguero wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2206/
> -----------------------------------------------------------
> =

> (Updated Nov. 27, 2012, 10:12 a.m.)
> =

> =

> Review request for Asterisk Developers.
> =

> =

> Summary
> -------
> =

> While troubleshooting another issue, came across this message in the debu=
g log:
> [2012-11-25 19:07:25] DEBUG[13375][C-00000007]: chan_sip.c:17910 check_vi=
a: NAT detected for 216.115.69.144:0 / 216.115.69.144:5060
> Sending to 216.115.69.144:5060 (NAT)
> =

> Upon looking at the code in check_via, I discovered that if the port is n=
ot set on the address in the VIA header, the default SIP port is not being =
set on struct ast_sockaddr tmp which is used to check if the requesting UA =
might be behind NAT.
> =

> =

> This addresses bug ASTERISK-20724.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20724
> =

> =

> Diffs
> -----
> =

>   branches/11/channels/chan_sip.c 376416 =

> =

> Diff: https://reviewboard.asterisk.org/r/2206/diff
> =

> =

> Testing
> -------
> =

> Local dev machine.
> =

> =

> Thanks,
> =

> elguero
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2206/">https://reviewboard.asterisk.org/r/2206/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good to go.</pre>  \
<br />

<p>- wdoekes</p>

<br />
<p>On November 27th, 2012, 10:12 a.m., elguero wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By elguero.</div>

<p style="color: grey;"><i>Updated Nov. 27, 2012, 10:12 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While troubleshooting another issue, came across this message in the \
debug log: [2012-11-25 19:07:25] DEBUG[13375][C-00000007]: chan_sip.c:17910 \
check_via: NAT detected for 216.115.69.144:0 / 216.115.69.144:5060 Sending to \
216.115.69.144:5060 (NAT)

Upon looking at the code in check_via, I discovered that if the port is not set on \
the address in the VIA header, the default SIP port is not being set on struct \
ast_sockaddr tmp which is used to check if the requesting UA might be behind \
NAT.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Local dev machine.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-20724">ASTERISK-20724</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/11/channels/chan_sip.c <span style="color: grey">(376416)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2206/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 