'Re: [asterisk-dev] [Code Review]: Who Hung Up Support for chan_motif'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review]: Who Hung Up Support for chan_motif
From:       "jcolp" <reviewboard () asterisk ! org>
Date:       2012-11-26 23:32:09
Message-ID: 20121126233209.28968.78609 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On Nov. 26, 2012, 4:18 p.m., Matt Jordan wrote:
> > The mapping specified in jingle_reason_mapping need to be documented on=
 the Asterisk wiki:
> > =

> > https://wiki.asterisk.org/wiki/display/AST/Hangup+Cause+Mappings

Done!

- jcolp

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2208/#review7436
-----------------------------------------------------------

On Nov. 26, 2012, 12:04 p.m., jcolp wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2208/
> -----------------------------------------------------------
> =

> (Updated Nov. 26, 2012, 12:04 p.m.)
> =

> =

> Review request for Asterisk Developers.
> =

> =

> Summary
> -------
> =

> This patch adds support for who hung up to chan_motif. The Jingle specifi=
c reason is made available, not just the cause code.
> =

> =

> Diffs
> -----
> =

>   /branches/11/channels/chan_motif.c 376141 =

> =

> Diff: https://reviewboard.asterisk.org/r/2208/diff
> =

> =

> Testing
> -------
> =

> Tested various session termination errors to make sure the reason is put =
in.
> =

> =

> Thanks,
> =

> jcolp
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2208/">https://reviewboard.asterisk.org/r/2208/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On November 26th, 2012, 4:18 p.m., <b>Matt \
Jordan</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">The mapping specified in jingle_reason_mapping need to be documented on \
the Asterisk wiki:

https://wiki.asterisk.org/wiki/display/AST/Hangup+Cause+Mappings</pre>
 </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Done!</pre> <br />

<p>- jcolp</p>

<br />
<p>On November 26th, 2012, 12:04 p.m., jcolp wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By jcolp.</div>

<p style="color: grey;"><i>Updated Nov. 26, 2012, 12:04 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for who hung up to chan_motif. The Jingle \
specific reason is made available, not just the cause code.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested various session termination errors to make sure the reason is put \
in.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/11/channels/chan_motif.c <span style="color: \
grey">(376141)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2208/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 