[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] Fix for chan_skinny leaving RTP ports open
From: "Mark Michelson" <reviewboard () asterisk ! org>
Date: 2012-10-31 16:14:25
Message-ID: 20121031161425.10098.65540 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2176/#review7344
-----------------------------------------------------------
Ship it!
This looks good by me.
- Mark
On Oct. 31, 2012, 2:30 a.m., wedhorn wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2176/
> -----------------------------------------------------------
> =
> (Updated Oct. 31, 2012, 2:30 a.m.)
> =
> =
> Review request for Asterisk Developers and Matt Jordan.
> =
> =
> Summary
> -------
> =
> Skinny wasn't closing RTP sockets. This patch includes ast_rtp_instance_s=
top before ast_rtp_instance_destroy which fixes the problem. Also add destr=
oy for VRTP (which I believe is unused, but exists). Also removed some blob=
s.
> =
> Not sure, but maybe ast_rtp_instance_destroy should first stop the RTP wh=
ich would make this patch redundant.
> =
> =
> Diffs
> -----
> =
> /branches/11/channels/chan_skinny.c 375469 =
> =
> Diff: https://reviewboard.asterisk.org/r/2176/diff
> =
> =
> Testing
> -------
> =
> Made a couple of calls and netstat'd the ports. All closed at end of call.
> =
> =
> Thanks,
> =
> wedhorn
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2176/">https://reviewboard.asterisk.org/r/2176/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This looks good by \
me.</pre> <br />
<p>- Mark</p>
<br />
<p>On October 31st, 2012, 2:30 a.m., wedhorn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers and Matt Jordan.</div>
<div>By wedhorn.</div>
<p style="color: grey;"><i>Updated Oct. 31, 2012, 2:30 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Skinny wasn't closing RTP sockets. This patch includes \
ast_rtp_instance_stop before ast_rtp_instance_destroy which fixes the problem. Also \
add destroy for VRTP (which I believe is unused, but exists). Also removed some \
blobs.
Not sure, but maybe ast_rtp_instance_destroy should first stop the RTP which would \
make this patch redundant.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Made a couple of calls and netstat'd the ports. All closed at end of \
call.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/11/channels/chan_skinny.c <span style="color: \
grey">(375469)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2176/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic