[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] SIP session timer tests for Require: timer header
From: "Olle E Johansson" <reviewboard () asterisk ! org>
Date: 2012-10-31 7:45:30
Message-ID: 20121031074530.23625.26886 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2173/#review7341
-----------------------------------------------------------
First, it would be nice to get some attribution here since I reported this =
bug in the existing code. Secondly, please take a look at my code for requi=
re in my PRACK branch. =
I added a more generic way to support Require headers, since if we have bot=
h session timers and PRACK and possibly something else, the Require header =
needs to list all of them. Your patch just solves it for timer, but will ca=
use issues if other extensions are required. Feel free to contact me if you=
need help finding it.
Basically I set flags for the required extensions, like we do with supporte=
d, then add the header in a generic way for all the required extensions.
- Olle E
On Oct. 30, 2012, 6:48 p.m., Mark Michelson wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2173/
> -----------------------------------------------------------
> =
> (Updated Oct. 30, 2012, 6:48 p.m.)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> These are accompanying tests for the changes in https://reviewboard.aster=
isk.org/r/2172
> =
> =
> This addresses bug ASTERISK-20570.
> https://issues.asterisk.org/jira/browse/ASTERISK-20570
> =
> =
> Diffs
> -----
> =
> /asterisk/trunk/tests/channels/SIP/session_timers_require/configs/ast1/=
extensions.conf PRE-CREATION =
> /asterisk/trunk/tests/channels/SIP/session_timers_require/configs/ast1/=
sip.conf PRE-CREATION =
> /asterisk/trunk/tests/channels/SIP/session_timers_require/sipp/uac-no-r=
efresher.xml PRE-CREATION =
> /asterisk/trunk/tests/channels/SIP/session_timers_require/sipp/uac-no-t=
imer-support.xml PRE-CREATION =
> /asterisk/trunk/tests/channels/SIP/session_timers_require/sipp/uac-refr=
esher-uac.xml PRE-CREATION =
> /asterisk/trunk/tests/channels/SIP/session_timers_require/sipp/uac-refr=
esher-uas.xml PRE-CREATION =
> /asterisk/trunk/tests/channels/SIP/session_timers_require/test-config.y=
aml PRE-CREATION =
> /asterisk/trunk/tests/channels/SIP/tests.yaml 3490 =
> =
> Diff: https://reviewboard.asterisk.org/r/2173/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Mark
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2173/">https://reviewboard.asterisk.org/r/2173/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">First, it would be nice \
to get some attribution here since I reported this bug in the existing code. \
Secondly, please take a look at my code for require in my PRACK branch.
I added a more generic way to support Require headers, since if we have both session \
timers and PRACK and possibly something else, the Require header needs to list all of \
them. Your patch just solves it for timer, but will cause issues if other extensions \
are required. Feel free to contact me if you need help finding it.
Basically I set flags for the required extensions, like we do with supported, then \
add the header in a generic way for all the required extensions.</pre> <br />
<p>- Olle E</p>
<br />
<p>On October 30th, 2012, 6:48 p.m., Mark Michelson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2012, 6:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">These are accompanying tests for the changes in \
https://reviewboard.asterisk.org/r/2172</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-20570">ASTERISK-20570</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/channels/SIP/session_timers_require/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/session_timers_require/configs/ast1/sip.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/session_timers_require/sipp/uac-no-refresher.xml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/session_timers_require/sipp/uac-no-timer-support.xml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/session_timers_require/sipp/uac-refresher-uac.xml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/session_timers_require/sipp/uac-refresher-uas.xml \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/session_timers_require/test-config.yaml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/channels/SIP/tests.yaml <span style="color: \
grey">(3490)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2173/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic