'Re: [asterisk-dev] [Code Review] chan_sip: Address reload problems against registry introduced by au'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] chan_sip: Address reload problems against registry introduced by au
From:       "jcolp" <reviewboard () asterisk ! org>
Date:       2012-10-30 19:16:16
Message-ID: 20121030191616.9189.65588 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2171/#review7340
-----------------------------------------------------------

Ship it!

- jcolp

On Oct. 30, 2012, 1:18 p.m., jrose wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2171/
> -----------------------------------------------------------
> =

> (Updated Oct. 30, 2012, 1:18 p.m.)
> =

> =

> Review request for Asterisk Developers and Matt Jordan.
> =

> =

> Summary
> -------
> =

> While working on a patch submitted by Kirill Katsnelson, I failed to noti=
ce that I introduced a somewhat breaking change against SIP reloads where t=
he registry would be pruned and couldn't be brought back without either res=
tarting Asterisk or fully unloading and reloading the chan_sip module. The =
problem occured when I moved the peer destruction marker callback to below =
the general section, at the time not having considered that peers could be =
created within the general section.
> =

> =

> This addresses bug ASTERISK-20611.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20611
> =

> =

> Diffs
> -----
> =

>   /branches/11/channels/chan_sip.c 375482 =

>   /branches/11/configs/sip.conf.sample 375482 =

> =

> Diff: https://reviewboard.asterisk.org/r/2171/diff
> =

> =

> Testing
> -------
> =

> Tested that the various autocreatepeer options still work.
> Tested that registry loads and reloads as expected.
> =

> =

> Thanks,
> =

> jrose
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2171/">https://reviewboard.asterisk.org/r/2171/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

<p>- jcolp</p>

<br />
<p>On October 30th, 2012, 1:18 p.m., jrose wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers and Matt Jordan.</div>
<div>By jrose.</div>

<p style="color: grey;"><i>Updated Oct. 30, 2012, 1:18 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">While working on a patch submitted by Kirill Katsnelson, I failed to \
notice that I introduced a somewhat breaking change against SIP reloads where the \
registry would be pruned and couldn&#39;t be brought back without either restarting \
Asterisk or fully unloading and reloading the chan_sip module. The problem occured \
when I moved the peer destruction marker callback to below the general section, at \
the time not having considered that peers could be created within the general \
section.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested that the various autocreatepeer options still work. Tested that \
registry loads and reloads as expected.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-20611">ASTERISK-20611</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/11/channels/chan_sip.c <span style="color: grey">(375482)</span></li>

 <li>/branches/11/configs/sip.conf.sample <span style="color: \
grey">(375482)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2171/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 