[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review]: Changes from Mantis ID 13495 in trunk.
From: "KNK" <reviewboard () asterisk ! org>
Date: 2012-08-31 8:57:20
Message-ID: 20120831085720.12706.12732 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Aug. 30, 2012, 1:27 p.m., rmudgett wrote:
> > I have committed Diff 13 plus fixing the finding in handle_ss7_linkset_mng() to \
> > the ss7_27_knk branch.
> > However, even with the SS7-27_libss7_trunk2_v1.diff patch from SS7-27 applied to \
> > libss7 I am still getting the message loop. You should to setup the local DAHDI \
> > spans to replicate. I described how to do that when I initially reported the \
> > problem. Local DAHDI spans do not need any hardware.
> > I am concerned that the libss7 trunk code is now including non-call related \
> > status information in the struct isup_call. The struct seems to be more like it \
> > should be called isup_circuit and thus should never be released unless the \
> > circuit is no longer provisioned. The got_sent_msg and timer[] members are the \
> > principle reasons that isup_call is no longer call related but circuit related.
>
> KNK wrote:
> Yes i am testing this with two local spans (dynamic=loc,1:0,31,0 and \
> dynamic=loc,1:1,31,0). My initial setup was with 6 timeslots per span (6 being the \
> signaling and 5 CICs). Later i have tested with 24 timeslots (T1) and 31 (E1) with \
> signalling on 1 and 16, CICs in a row (cicbeginswitch=1 only) and in two separate \
> groups (cicgeinswitch 1 and 17 skipping 16 as signaling) ... over 50 restarts \
> without causing a message loop even once.
> I do not quite agree with isup_circuit and not releasing the call - it's more like \
> 'events sequence' than call or circuit and applies to both ... but will think a bit \
> more on this
> rmudgett wrote:
> I found that the loop happens if I have
> ss7type=ansi
> It does not happen if I have
> ss7type=itu
Thank you!
isup.c around line 4338 "T1.113 requires sending GRS twice", so the second one is \
unexpected. I will see how it can be fixed, but most likely "Take independent action \
on every Circuit Group Reset Message received" instead of introducing T(RGS) 5sec \
timer as per T1.113 2.9.3.2 Before fixing this i will check where our ISUP_SENT_RSC \
is lost which will still cause the loop in the first place
- KNK
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1676/#review6978
-----------------------------------------------------------
On Aug. 20, 2012, 6:35 a.m., KNK wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1676/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2012, 6:35 a.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> chan_dahdi / sig_ss7 part of changes
>
>
> This addresses bug SS7-27.
> https://issues.asterisk.org/jira/browse/SS7-27
>
>
> Diffs
> -----
>
> trunk/channels/chan_dahdi.c 371534
> trunk/channels/sig_ss7.h 371534
> trunk/channels/sig_ss7.c 371534
> trunk/configs/chan_dahdi.conf.sample 371534
> trunk/configs/ss7.timers.sample PRE-CREATION
> trunk/configure.ac 371534
>
> Diff: https://reviewboard.asterisk.org/r/1676/diff
>
>
> Testing
> -------
>
> compiles, link setup, cli commands, bassic calls, connected line and redirection.
>
>
> Thanks,
>
> KNK
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1676/">https://reviewboard.asterisk.org/r/1676/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On August 30th, 2012, 1:27 p.m., <b>rmudgett</b> \
wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; \
padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have \
committed Diff 13 plus fixing the finding in handle_ss7_linkset_mng() to the \
ss7_27_knk branch.
However, even with the SS7-27_libss7_trunk2_v1.diff patch from SS7-27 applied to \
libss7 I am still getting the message loop. You should to setup the local DAHDI \
spans to replicate. I described how to do that when I initially reported the \
problem. Local DAHDI spans do not need any hardware.
I am concerned that the libss7 trunk code is now including non-call related status \
information in the struct isup_call. The struct seems to be more like it should be \
called isup_circuit and thus should never be released unless the circuit is no longer \
provisioned. The got_sent_msg and timer[] members are the principle reasons that \
isup_call is no longer call related but circuit related. </pre>
</blockquote>
<p>On August 30th, 2012, 3:48 p.m., <b>KNK</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes i am testing this \
with two local spans (dynamic=loc,1:0,31,0 and dynamic=loc,1:1,31,0). My initial \
setup was with 6 timeslots per span (6 being the signaling and 5 CICs). Later i have \
tested with 24 timeslots (T1) and 31 (E1) with signalling on 1 and 16, CICs in a row \
(cicbeginswitch=1 only) and in two separate groups (cicgeinswitch 1 and 17 skipping \
16 as signaling) ... over 50 restarts without causing a message loop even once.
I do not quite agree with isup_circuit and not releasing the call - it's more \
like 'events sequence' than call or circuit and applies to both ... but will \
think a bit more on this</pre> </blockquote>
<p>On August 30th, 2012, 4:42 p.m., <b>rmudgett</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I found that the loop \
happens if I have ss7type=ansi
It does not happen if I have
ss7type=itu</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you! isup.c around \
line 4338 "T1.113 requires sending GRS twice", so the second one is \
unexpected. I will see how it can be fixed, but most likely "Take independent \
action on every Circuit Group Reset Message received" instead of introducing \
T(RGS) 5sec timer as per T1.113 2.9.3.2 Before fixing this i will check where our \
ISUP_SENT_RSC is lost which will still cause the loop in the first place</pre> <br />
<p>- KNK</p>
<br />
<p>On August 20th, 2012, 6:35 a.m., KNK wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By KNK.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2012, 6:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">chan_dahdi / sig_ss7 part of changes</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">compiles, link setup, cli commands, bassic calls, connected line and \
redirection.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/SS7-27">SS7-27</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/channels/chan_dahdi.c <span style="color: grey">(371534)</span></li>
<li>trunk/channels/sig_ss7.h <span style="color: grey">(371534)</span></li>
<li>trunk/channels/sig_ss7.c <span style="color: grey">(371534)</span></li>
<li>trunk/configs/chan_dahdi.conf.sample <span style="color: \
grey">(371534)</span></li>
<li>trunk/configs/ss7.timers.sample <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>trunk/configure.ac <span style="color: grey">(371534)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1676/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic