[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] Fix SEQNO on retransmitted DTMF event END packets not being increme
From: "Mark Michelson" <reviewboard () asterisk ! org>
Date: 2012-08-30 13:58:34
Message-ID: 20120830135834.16213.84254 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2083/#review6975
-----------------------------------------------------------
Ship it!
- Mark
On Aug. 24, 2012, 12:01 p.m., elguero wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2083/
> -----------------------------------------------------------
> =
> (Updated Aug. 24, 2012, 12:01 p.m.)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> When sending the DTMF event END packet, the two retransmitted packets hav=
e the same sequence number as the first transmitted packet.
> =
> RFC 4733 Sect. 2.5.1.6. RTP Sequence Number
> "The RTP sequence number MUST be incremented by one in each successive RT=
P packet sent. Incrementing applies to retransmitted as well as initial ins=
tances of event reports, to permit the receiver to detect lost packets for =
RTP Control Protocol (RTCP) receiver reports."
> =
> This patch is based on the reporters patch which I have fixed up to meet =
our code submission guidelines and moved the incrementation of seqno down t=
o below a debug message so that the debug message displays the correct seqn=
o that was transmitted.
> =
> Cleaned up a couple of lines as well while I was looking at the code that=
were essentially not needed.
> =
> =
> This addresses bug ASTERISK-20295.
> https://issues.asterisk.org/jira/browse/ASTERISK-20295
> =
> =
> Diffs
> -----
> =
> /trunk/res/res_rtp_asterisk.c 371620 =
> =
> Diff: https://reviewboard.asterisk.org/r/2083/diff
> =
> =
> Testing
> -------
> =
> Tested on local dev box. Did a packet capture to confirm that the seqno =
was being incremented properly when sending DTMF.
> =
> =
> Thanks,
> =
> elguero
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2083/">https://reviewboard.asterisk.org/r/2083/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- Mark</p>
<br />
<p>On August 24th, 2012, 12:01 p.m., elguero wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By elguero.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2012, 12:01 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">When sending the DTMF event END packet, the two retransmitted packets \
have the same sequence number as the first transmitted packet.
RFC 4733 Sect. 2.5.1.6. RTP Sequence Number
"The RTP sequence number MUST be incremented by one in each successive RTP \
packet sent. Incrementing applies to retransmitted as well as initial instances of \
event reports, to permit the receiver to detect lost packets for RTP Control Protocol \
(RTCP) receiver reports."
This patch is based on the reporters patch which I have fixed up to meet our code \
submission guidelines and moved the incrementation of seqno down to below a debug \
message so that the debug message displays the correct seqno that was transmitted.
Cleaned up a couple of lines as well while I was looking at the code that were \
essentially not needed.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on local dev box. Did a packet capture to confirm that the seqno \
was being incremented properly when sending DTMF.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-20295">ASTERISK-20295</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/res_rtp_asterisk.c <span style="color: grey">(371620)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2083/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic