'[asterisk-dev] [Code Review] Test device state notifications in chan_sip'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    [asterisk-dev] [Code Review] Test device state notifications in chan_sip
From:       "Mark Michelson" <reviewboard () asterisk ! org>
Date:       2012-08-29 17:33:27
Message-ID: 20120829173327.9891.67012 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2090/
-----------------------------------------------------------

Review request for Asterisk Developers.

Summary
-------

Due to an issue being reported against Asterisk 11 because of RINGING devic=
e state notifications not being sent to SIP phones, I have created a simple=
 test that ensures that device state changes result in notifications being =
sent to SIP subscribers.

This test has a single subscriber subscribe to a custom device state. Then =
the custom device state is changed to RINGING, to INUSE, and then to NOT_IN=
USE. We ensure that all three changes result in NOTIFYs being sent to the s=
ubscriber.

Note that for this test to pass currently in Asterisk 11 or Asterisk trunk,=
 the patch from ASTERISK-20297 must first be applied. It has not been commi=
tted yet.

This addresses bug ASTERISK-20297.
    https://issues.asterisk.org/jira/browse/ASTERISK-20297

Diffs
-----

  /asterisk/trunk/lib/python/asterisk/TestCase.py 3422 =

  /asterisk/trunk/tests/channels/SIP/device_state_notification/Originator.p=
y PRE-CREATION =

  /asterisk/trunk/tests/channels/SIP/device_state_notification/configs/ast1=
/extensions.conf PRE-CREATION =

  /asterisk/trunk/tests/channels/SIP/device_state_notification/configs/ast1=
/sip.conf PRE-CREATION =

  /asterisk/trunk/tests/channels/SIP/device_state_notification/sipp/uac-sub=
scribe-unsubscribe.xml PRE-CREATION =

  /asterisk/trunk/tests/channels/SIP/device_state_notification/test-config.=
yaml PRE-CREATION =

  /asterisk/trunk/tests/channels/SIP/tests.yaml 3422 =

Diff: https://reviewboard.asterisk.org/r/2090/diff

Testing
-------

Thanks,

Mark

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/2090/">https://reviewboard.asterisk.org/r/2090/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Mark Michelson.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Due to an issue being reported against Asterisk 11 because of RINGING \
device state notifications not being sent to SIP phones, I have created a simple test \
that ensures that device state changes result in notifications being sent to SIP \
subscribers.

This test has a single subscriber subscribe to a custom device state. Then the custom \
device state is changed to RINGING, to INUSE, and then to NOT_INUSE. We ensure that \
all three changes result in NOTIFYs being sent to the subscriber.

Note that for this test to pass currently in Asterisk 11 or Asterisk trunk, the patch \
from ASTERISK-20297 must first be applied. It has not been committed yet.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://issues.asterisk.org/jira/browse/ASTERISK-20297">ASTERISK-20297</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/asterisk/trunk/lib/python/asterisk/TestCase.py <span style="color: \
grey">(3422)</span></li>

 <li>/asterisk/trunk/tests/channels/SIP/device_state_notification/Originator.py <span \
style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/SIP/device_state_notification/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/SIP/device_state_notification/configs/ast1/sip.conf \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/SIP/device_state_notification/sipp/uac-subscribe-unsubscribe.xml \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/SIP/device_state_notification/test-config.yaml \
<span style="color: grey">(PRE-CREATION)</span></li>

 <li>/asterisk/trunk/tests/channels/SIP/tests.yaml <span style="color: \
grey">(3422)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/2090/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 