[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] ICE, STUN, and TURN Support
From: "opticron" <reviewboard () asterisk ! org>
Date: 2012-06-27 18:59:50
Message-ID: 20120627185950.9759.8008 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1891/#review6591
-----------------------------------------------------------
Ship it!
Looks good!
/trunk/res/res_rtp_asterisk.c
<https://reviewboard.asterisk.org/r/1891/#comment12500>
It would be nice if bzero was set to something unusable again here (pre=
ferably the warning used before) so that it can not be used later in the fi=
le.
- opticron
On May 29, 2012, 2:16 p.m., Joshua Colp wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1891/
> -----------------------------------------------------------
> =
> (Updated May 29, 2012, 2:16 p.m.)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> This patch adds support for the following:
> =
> ICE attribute parsing and generation in chan_sip
> Usage of the ICE interface in chan_sip
> ICE support within res_rtp_asterisk
> STUN support within res_rtp_asterisk for getting the server reflexive add=
ress
> TURN support within res_rtp_asterisk for relaying traffic when needed
> Additional configuration options for the above
> =
> One area which could use some feedback is the pjproject integration. Shou=
ld we try to use their build system as I have done to integrate things, or =
try to roll their stuff into ours further?
> =
> If you would like some background on ICE and the actual support here take=
a gander at the wiki page located at https://wiki.asterisk.org/wiki/displa=
y/~jcolp/ICE%2C+STUN%2C+and+TURN+Support - hopefully it proves useful to yo=
u.
> =
> =
> Diffs
> -----
> =
> /trunk/channels/chan_sip.c 361952 =
> /trunk/configs/rtp.conf.sample 361952 =
> /trunk/include/asterisk/rtp_engine.h 361952 =
> /trunk/main/rtp_engine.c 361952 =
> /trunk/res/Makefile 361952 =
> /trunk/res/res_rtp_asterisk.c 361952 =
> =
> Diff: https://reviewboard.asterisk.org/r/1891/diff
> =
> =
> Testing
> -------
> =
> Tested various scenarios using Bria and X-Lite behind multiple NATs, diff=
erent NATs, different internet connections but locally reachable, etc. It w=
orks well.
> =
> =
> Thanks,
> =
> Joshua
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1891/">https://reviewboard.asterisk.org/r/1891/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks good!</pre> <br \
/>
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/1891/diff/3/?file=28392#file28392line50" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/res/res_rtp_asterisk.c</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">50</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It would be \
nice if bzero was set to something unusable again here (preferably the warning used \
before) so that it can not be used later in the file.</pre> </div>
<br />
<p>- opticron</p>
<br />
<p>On May 29th, 2012, 2:16 p.m., Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated May 29, 2012, 2:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds support for the following:
ICE attribute parsing and generation in chan_sip
Usage of the ICE interface in chan_sip
ICE support within res_rtp_asterisk
STUN support within res_rtp_asterisk for getting the server reflexive address
TURN support within res_rtp_asterisk for relaying traffic when needed
Additional configuration options for the above
One area which could use some feedback is the pjproject integration. Should we try to \
use their build system as I have done to integrate things, or try to roll their stuff \
into ours further?
If you would like some background on ICE and the actual support here take a gander at \
the wiki page located at \
https://wiki.asterisk.org/wiki/display/~jcolp/ICE%2C+STUN%2C+and+TURN+Support - \
hopefully it proves useful to you.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested various scenarios using Bria and X-Lite behind multiple NATs, \
different NATs, different internet connections but locally reachable, etc. It works \
well.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_sip.c <span style="color: grey">(361952)</span></li>
<li>/trunk/configs/rtp.conf.sample <span style="color: grey">(361952)</span></li>
<li>/trunk/include/asterisk/rtp_engine.h <span style="color: \
grey">(361952)</span></li>
<li>/trunk/main/rtp_engine.c <span style="color: grey">(361952)</span></li>
<li>/trunk/res/Makefile <span style="color: grey">(361952)</span></li>
<li>/trunk/res/res_rtp_asterisk.c <span style="color: grey">(361952)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1891/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic