[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] SDP Media Attribute Interface + H.263/H.264 Format Attribute Module
From: "Mark Michelson" <reviewboard () asterisk ! org>
Date: 2012-06-27 16:19:44
Message-ID: 20120627161944.30266.56505 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2005/#review6589
-----------------------------------------------------------
Ship it!
I'm giving a "ship it" due to the testing you said you've done. I'd feel be=
tter if there were unit tests added to ensure that SDP is parsed and genera=
ted properly.
/trunk/res/res_format_attr_h264.c
<https://reviewboard.asterisk.org/r/2005/#comment12498>
redness
/trunk/res/res_format_attr_silk.c
<https://reviewboard.asterisk.org/r/2005/#comment12499>
your code is blushing
- Mark
On June 27, 2012, 7:52 a.m., Joshua Colp wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2005/
> -----------------------------------------------------------
> =
> (Updated June 27, 2012, 7:52 a.m.)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> This patch adds to the format attribute interface two methods used to par=
se and generate SDP for formats. It also adds two format attribute modules =
- one for H.263 and one for H.264. The SDP logic for CELT and SILK have als=
o been moved to their respective format attribute modules.
> =
> =
> Diffs
> -----
> =
> /trunk/channels/chan_sip.c 368849 =
> /trunk/include/asterisk/format.h 368849 =
> /trunk/main/format.c 368849 =
> /trunk/main/translate.c 368849 =
> /trunk/res/res_format_attr_celt.c 368849 =
> /trunk/res/res_format_attr_h263.c PRE-CREATION =
> /trunk/res/res_format_attr_h264.c PRE-CREATION =
> /trunk/res/res_format_attr_silk.c 368849 =
> =
> Diff: https://reviewboard.asterisk.org/r/2005/diff
> =
> =
> Testing
> -------
> =
> Performed heavy testing of H.263 and H.264 format attribute modules using=
various softphones and different scenarios.
> =
> =
> Thanks,
> =
> Joshua
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/2005/">https://reviewboard.asterisk.org/r/2005/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm giving a \
"ship it" due to the testing you said you've done. I'd feel better \
if there were unit tests added to ensure that SDP is parsed and generated \
properly.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2005/diff/1/?file=29253#file29253line269" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/res/res_format_attr_h264.c</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">static void h264_format_attr_sdp_generate(const struct ast_format_attr \
*format_attr, unsigned int payload, struct ast_str **str)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">269</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="ew"> </span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">redness</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://reviewboard.asterisk.org/r/2005/diff/1/?file=29254#file29254line72" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/res/res_format_attr_silk.c</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">static void silk_sdp_generate(const struct ast_format_attr *format_attr, \
unsigned int payload, struct ast_str **str)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">72</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">((</span><span class="n">attr</span><span \
class="o">-></span><span class="n">maxbitrate</span> <span class="o">></span> \
<span class="mi">5000</span><span class="p">)</span> <span \
class="o">&&</span> <span class="p">(</span><span class="n">attr</span><span \
class="o">-></span><span class="n">maxbitrate</span> <span class="o"><</span> \
<span class="mi">40000</span><span class="p">))</span> <span class="p">{</span><span \
class="ew"> </span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">your code \
is blushing</pre> </div>
<br />
<p>- Mark</p>
<br />
<p>On June 27th, 2012, 7:52 a.m., Joshua Colp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Joshua Colp.</div>
<p style="color: grey;"><i>Updated June 27, 2012, 7:52 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch adds to the format attribute interface two methods used to \
parse and generate SDP for formats. It also adds two format attribute modules - one \
for H.263 and one for H.264. The SDP logic for CELT and SILK have also been moved to \
their respective format attribute modules.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Performed heavy testing of H.263 and H.264 format attribute modules \
using various softphones and different scenarios.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_sip.c <span style="color: grey">(368849)</span></li>
<li>/trunk/include/asterisk/format.h <span style="color: grey">(368849)</span></li>
<li>/trunk/main/format.c <span style="color: grey">(368849)</span></li>
<li>/trunk/main/translate.c <span style="color: grey">(368849)</span></li>
<li>/trunk/res/res_format_attr_celt.c <span style="color: grey">(368849)</span></li>
<li>/trunk/res/res_format_attr_h263.c <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/res/res_format_attr_h264.c <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/res/res_format_attr_silk.c <span style="color: grey">(368849)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/2005/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic