[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] logger: Call ID logging phase III part 1 split - chan_iax2 and chan
From: "rmudgett" <reviewboard () asterisk ! org>
Date: 2012-06-26 21:35:23
Message-ID: 20120626213523.11700.92744 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1927/#review6579
-----------------------------------------------------------
Ship it!
- rmudgett
On June 26, 2012, 3:50 p.m., jrose wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1927/
> -----------------------------------------------------------
> =
> (Updated June 26, 2012, 3:50 p.m.)
> =
> =
> Review request for Asterisk Developers, rmudgett and Matt Jordan.
> =
> =
> Summary
> -------
> =
> split from: https://reviewboard.asterisk.org/r/1886/
> These changes allow channels dahdi and iax2 to set callids and bind log m=
essages to callids.
> =
> This is the same code as in the earlier review. It was split to commit t=
he approved parts and to hopefully encourage some review of the remaining p=
arts since there is less in here to review now.
> =
> =
> Diffs
> -----
> =
> /trunk/channels/chan_agent.c 369392 =
> /trunk/channels/chan_dahdi.c 369392 =
> /trunk/channels/chan_iax2.c 369392 =
> /trunk/channels/chan_local.c 369392 =
> /trunk/channels/sig_analog.c 369392 =
> /trunk/channels/sig_pri.c 369392 =
> /trunk/channels/sig_ss7.c 369392 =
> /trunk/include/asterisk/logger.h 369392 =
> /trunk/main/autoservice.c 369392 =
> /trunk/main/bridging.c 369392 =
> /trunk/main/channel_internal_api.c 369392 =
> /trunk/main/cli.c 369392 =
> /trunk/main/features.c 369392 =
> /trunk/main/logger.c 369392 =
> /trunk/main/pbx.c 369392 =
> =
> Diff: https://reviewboard.asterisk.org/r/1927/diff
> =
> =
> Testing
> -------
> =
> see https://reviewboard.asterisk.org/r/1886/
> =
> =
> Thanks,
> =
> jrose
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1927/">https://reviewboard.asterisk.org/r/1927/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<p>- rmudgett</p>
<br />
<p>On June 26th, 2012, 3:50 p.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers, rmudgett and Matt Jordan.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated June 26, 2012, 3:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">split from: https://reviewboard.asterisk.org/r/1886/ These changes allow \
channels dahdi and iax2 to set callids and bind log messages to callids.
This is the same code as in the earlier review. It was split to commit the approved \
parts and to hopefully encourage some review of the remaining parts since there is \
less in here to review now.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">see https://reviewboard.asterisk.org/r/1886/</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/channels/chan_agent.c <span style="color: grey">(369392)</span></li>
<li>/trunk/channels/chan_dahdi.c <span style="color: grey">(369392)</span></li>
<li>/trunk/channels/chan_iax2.c <span style="color: grey">(369392)</span></li>
<li>/trunk/channels/chan_local.c <span style="color: grey">(369392)</span></li>
<li>/trunk/channels/sig_analog.c <span style="color: grey">(369392)</span></li>
<li>/trunk/channels/sig_pri.c <span style="color: grey">(369392)</span></li>
<li>/trunk/channels/sig_ss7.c <span style="color: grey">(369392)</span></li>
<li>/trunk/include/asterisk/logger.h <span style="color: grey">(369392)</span></li>
<li>/trunk/main/autoservice.c <span style="color: grey">(369392)</span></li>
<li>/trunk/main/bridging.c <span style="color: grey">(369392)</span></li>
<li>/trunk/main/channel_internal_api.c <span style="color: \
grey">(369392)</span></li>
<li>/trunk/main/cli.c <span style="color: grey">(369392)</span></li>
<li>/trunk/main/features.c <span style="color: grey">(369392)</span></li>
<li>/trunk/main/logger.c <span style="color: grey">(369392)</span></li>
<li>/trunk/main/pbx.c <span style="color: grey">(369392)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1927/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic