[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] Add replacement for SIP_CAUSE
From: "opticron" <reviewboard () asterisk ! org>
Date: 2012-03-27 13:51:56
Message-ID: 20120327135156.7972.3711 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1822/
-----------------------------------------------------------
(Updated March 27, 2012, 8:51 a.m.)
Review request for Asterisk Developers.
Changes
-------
Tweaks to the description of this review.
Summary (updated)
-------
Add HANGUPCAUSE as a drop-in replacement for SIP_CAUSE that does not incur the \
overhead of the MASTER_CHANNEL dialplan function. This feature uses control frames \
to pass the data and creates a mechanism by which any channel driver can report cause \
information. This implementation includes only SIP, but implementations for other \
channel drivers will be available in the next month.
This addresses bug SWP-4221.
https://issues.asterisk.org/jira/browse/SWP-4221
Diffs
-----
trunk/CHANGES 360259
trunk/UPGRADE.txt 360259
trunk/apps/app_dial.c 360259
trunk/apps/app_followme.c 360259
trunk/apps/app_queue.c 360259
trunk/channels/chan_alsa.c 360259
trunk/channels/chan_console.c 360259
trunk/channels/chan_gtalk.c 360259
trunk/channels/chan_h323.c 360259
trunk/channels/chan_iax2.c 360259
trunk/channels/chan_jingle.c 360259
trunk/channels/chan_mgcp.c 360259
trunk/channels/chan_misdn.c 360259
trunk/channels/chan_oss.c 360259
trunk/channels/chan_phone.c 360259
trunk/channels/chan_sip.c 360259
trunk/channels/chan_skinny.c 360259
trunk/channels/chan_unistim.c 360259
trunk/channels/chan_vpb.cc 360259
trunk/funcs/func_frame_trace.c 360259
trunk/include/asterisk/frame.h 360259
trunk/main/channel.c 360259
trunk/main/dial.c 360259
trunk/main/features.c 360259
trunk/main/file.c 360259
trunk/main/rtp_engine.c 360259
Diff: https://reviewboard.asterisk.org/r/1822/diff
Testing (updated)
-------
Verified that this functions identically to SIP_CAUSE in single-channel dials, forked \
dials, and forked dials behind a local dial.
Sample dialplan:
[foo]
exten => s,1,Dial(SIP/bar)
exten => h,1,noop()
exten => h,n,set(HANGUPCAUSE_STRING=${HASHKEYS(HANGUPCAUSE)})
; start loop
exten => h,n(begin),noop()
; check exit condition (no more array to check)
exten => h,n,gotoif($[${LEN(${HANGUPCAUSE_STRING})} = 0]?exit)
; pull the next item
exten => h,n,set(ARRAY(item)=${HANGUPCAUSE_STRING})
exten => h,n,set(HANGUPCAUSE_STRING=${HANGUPCAUSE_STRING:${LEN(${item})}})
; display the channel ID and cause code
exten => h,n,noop(got channel ID ${item} with pvt cause ${HASH(HANGUPCAUSE,${item})})
; check exit condition (no more array to check)
exten => h,n,gotoif($[${LEN(${HANGUPCAUSE_STRING})} = 0]?exit)
; we still have entries to process, so strip the leading comma
exten => h,n,set(HANGUPCAUSE_STRING=${HANGUPCAUSE_STRING:1})
; go back to the beginning of the loop
exten => h,n,goto(begin)
exten => h,n(exit),noop(All HANGUPCAUSE entries processed)
Thanks,
opticron
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1822/">https://reviewboard.asterisk.org/r/1822/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By opticron.</div>
<p style="color: grey;"><i>Updated March 27, 2012, 8:51 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tweaks to the description of this review.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Add HANGUPCAUSE as a drop-in replacement for SIP_CAUSE that does not \
incur the overhead of the MASTER_CHANNEL dialplan function. This feature uses \
control frames to pass the data and creates a mechanism by which any channel driver \
can report cause information. This implementation includes only SIP, but \
implementations for other channel drivers will be available in the next month.</pre> \
</td> </tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Verified that this functions identically to SIP_CAUSE in single-channel \
dials, forked dials, and forked dials behind a local dial.
Sample dialplan:
[foo]
exten => s,1,Dial(SIP/bar)
exten => h,1,noop()
exten => h,n,set(HANGUPCAUSE_STRING=${HASHKEYS(HANGUPCAUSE)})
; start loop
exten => h,n(begin),noop()
; check exit condition (no more array to check)
exten => h,n,gotoif($[${LEN(${HANGUPCAUSE_STRING})} = 0]?exit)
; pull the next item
exten => h,n,set(ARRAY(item)=${HANGUPCAUSE_STRING})
exten => h,n,set(HANGUPCAUSE_STRING=${HANGUPCAUSE_STRING:${LEN(${item})}})
; display the channel ID and cause code
exten => h,n,noop(got channel ID ${item} with pvt cause \
${HASH(HANGUPCAUSE,${item})})
; check exit condition (no more array to check)
exten => h,n,gotoif($[${LEN(${HANGUPCAUSE_STRING})} = 0]?exit)
; we still have entries to process, so strip the leading comma
exten => h,n,set(HANGUPCAUSE_STRING=${HANGUPCAUSE_STRING:1})
; go back to the beginning of the loop
exten => h,n,goto(begin)
exten => h,n(exit),noop(All HANGUPCAUSE entries processed)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/SWP-4221">SWP-4221</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/CHANGES <span style="color: grey">(360259)</span></li>
<li>trunk/UPGRADE.txt <span style="color: grey">(360259)</span></li>
<li>trunk/apps/app_dial.c <span style="color: grey">(360259)</span></li>
<li>trunk/apps/app_followme.c <span style="color: grey">(360259)</span></li>
<li>trunk/apps/app_queue.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_alsa.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_console.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_gtalk.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_h323.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_iax2.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_jingle.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_mgcp.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_misdn.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_oss.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_phone.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_sip.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_skinny.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_unistim.c <span style="color: grey">(360259)</span></li>
<li>trunk/channels/chan_vpb.cc <span style="color: grey">(360259)</span></li>
<li>trunk/funcs/func_frame_trace.c <span style="color: grey">(360259)</span></li>
<li>trunk/include/asterisk/frame.h <span style="color: grey">(360259)</span></li>
<li>trunk/main/channel.c <span style="color: grey">(360259)</span></li>
<li>trunk/main/dial.c <span style="color: grey">(360259)</span></li>
<li>trunk/main/features.c <span style="color: grey">(360259)</span></li>
<li>trunk/main/file.c <span style="color: grey">(360259)</span></li>
<li>trunk/main/rtp_engine.c <span style="color: grey">(360259)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1822/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic