[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review]: Baseline test for bridge application
From: "jrose" <reviewboard () asterisk ! org>
Date: 2012-03-23 18:30:10
Message-ID: 20120323183010.10194.27586 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On March 23, 2012, 12:03 p.m., Mark Michelson wrote:
> > Mostly good. The only thing I don't like are the timed waits in the dia=
lplan. This is the sort of thing that tends to make tests bounce when they'=
re run by bamboo agents. A better plan is to change the apps in the call1 a=
nd call2 contexts to Echo, so that the channels will stay up for as long as=
necessary. Then in the function where you handle the BridgeExec manager ev=
ent, you can send an AMI hangup to get the channels to hang up.
> > =
> > While I am recommending the Echo app, I seem to recall Kinsey mentionin=
g something recently about how having two Local channels bridged together a=
nd having them both Echo() caused bad things to happen for him. As an alter=
native, you could use WaitUntil(2100000000) which would mean that the chann=
els would wait until July of 2036. Or you could have them both use Chanspy(=
) and spy on a non-existent channel, just so the channels will stay up unti=
l you tell them to hang up from the test.
> =
> Mark Michelson wrote:
> Oh, same goes for call@test_context as well.
> =
> jrose wrote:
> For some crazy reason in spite of that being a considerable while bef=
ore 2038, that fails on me with citing the time as being in the past.
> =
> Winding 2100000000 back to 2090000000 works just fine though.
And that's no longer relevant anyway, so myeeeeeh. Oh well, the whole thin=
g shaved 8 seconds off the test anyway, so cool.
- jrose
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1828/#review5883
-----------------------------------------------------------
On March 23, 2012, 10:33 a.m., jrose wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1828/
> -----------------------------------------------------------
> =
> (Updated March 23, 2012, 10:33 a.m.)
> =
> =
> Review request for Asterisk Developers, Matt Jordan and pabelganger.
> =
> =
> Summary
> -------
> =
> Baseline test for bridge, Bridges a call and checks to see if a successfu=
l bridge event occured.
> =
> Somewhat based on the queue baseline test.
> =
> =
> Diffs
> -----
> =
> /asterisk/trunk/tests/apps/bridge/bridge_baseline/configs/ast1/extensio=
ns.conf PRE-CREATION =
> /asterisk/trunk/tests/apps/bridge/bridge_baseline/run-test PRE-CREATION =
> /asterisk/trunk/tests/apps/bridge/bridge_baseline/test-config.yaml PRE-=
CREATION =
> /asterisk/trunk/tests/apps/bridge/tests.yaml PRE-CREATION =
> /asterisk/trunk/tests/apps/tests.yaml 3121 =
> =
> Diff: https://reviewboard.asterisk.org/r/1828/diff
> =
> =
> Testing
> -------
> =
> Ran the test a few times, followed what was happening, etc.
> =
> =
> Thanks,
> =
> jrose
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1828/">https://reviewboard.asterisk.org/r/1828/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On March 23rd, 2012, 12:03 p.m., <b>Mark \
Michelson</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Mostly good. The only thing I don't like are the timed waits in the \
dialplan. This is the sort of thing that tends to make tests bounce when they're \
run by bamboo agents. A better plan is to change the apps in the call1 and call2 \
contexts to Echo, so that the channels will stay up for as long as necessary. Then in \
the function where you handle the BridgeExec manager event, you can send an AMI \
hangup to get the channels to hang up.
While I am recommending the Echo app, I seem to recall Kinsey mentioning something \
recently about how having two Local channels bridged together and having them both \
Echo() caused bad things to happen for him. As an alternative, you could use \
WaitUntil(2100000000) which would mean that the channels would wait until July of \
2036. Or you could have them both use Chanspy() and spy on a non-existent channel, \
just so the channels will stay up until you tell them to hang up from the test.</pre> \
</blockquote>
<p>On March 23rd, 2012, 12:04 p.m., <b>Mark Michelson</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oh, same goes for \
call@test_context as well.</pre> </blockquote>
<p>On March 23rd, 2012, 1:26 p.m., <b>jrose</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For some crazy reason in \
spite of that being a considerable while before 2038, that fails on me with citing \
the time as being in the past.
Winding 2100000000 back to 2090000000 works just fine though.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">And that's no longer \
relevant anyway, so myeeeeeh. Oh well, the whole thing shaved 8 seconds off the test \
anyway, so cool.</pre> <br />
<p>- jrose</p>
<br />
<p>On March 23rd, 2012, 10:33 a.m., jrose wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers, Matt Jordan and pabelganger.</div>
<div>By jrose.</div>
<p style="color: grey;"><i>Updated March 23, 2012, 10:33 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Baseline test for bridge, Bridges a call and checks to see if a \
successful bridge event occured.
Somewhat based on the queue baseline test.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran the test a few times, followed what was happening, etc.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/apps/bridge/bridge_baseline/configs/ast1/extensions.conf \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/bridge/bridge_baseline/run-test <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/bridge/bridge_baseline/test-config.yaml <span \
style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/bridge/tests.yaml <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/apps/tests.yaml <span style="color: \
grey">(3121)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1828/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic