[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] copy accountcode to accountcode, not peeraccount in app_dial
From: "rmudgett" <reviewboard () asterisk ! org>
Date: 2012-02-29 0:22:41
Message-ID: 20120229002241.14648.14715 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1775/#review5672
-----------------------------------------------------------
Ship it!
As far as I can tell, the change to set peeraccount was wrong. All the oth=
er places that create an outgoing channel set the accountcode from the init=
iating channel.
- rmudgett
On Feb. 28, 2012, 2:51 p.m., wdoekes wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1775/
> -----------------------------------------------------------
> =
> (Updated Feb. 28, 2012, 2:51 p.m.)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> r203638 | russell | 2009-06-26 17:28:53 +0200 (Fri, 26 Jun 2009) | 14 lin=
es
> added the CEL event logging subsystem.
> =
> When this got added to trunk, the bug of ASTERISK-19384 started to appear.
> =
> jamicque spotted the difference between peeraccount and account in app_di=
al:
> =
> - ast_string_field_set(tc, accountcode, chan->accountcode);
> + if (!ast_strlen_zero(chan->accountcode)) {
> + ast_string_field_set(tc, peeraccount, chan->accou=
ntcode);
> + }
> =
> He attached accountcode.patch (License #6033) to the bugreport which chan=
ges that peeraccount into accountcode.
> =
> Was this a typo? Or was this meant to be changed?
> =
> If we apply the patch, the expected CDR behaviour with regards to the acc=
ountcode is restored.
> =
> =
> This addresses bug ASTERISK-19384.
> https://issues.asterisk.org/jira/browse/ASTERISK-19384
> =
> =
> Diffs
> -----
> =
> /branches/1.8/apps/app_dial.c 357402 =
> =
> Diff: https://reviewboard.asterisk.org/r/1775/diff
> =
> =
> Testing
> -------
> =
> 10 out of 10 of the testsuite cdr tests that run on my system still run s=
uccessfully after applying the patch.
> =
> And now the 11th test (r1765) runs succesfully some of the time. (Only so=
metimes because of the undefined CDR order, this has to be fixed in the tes=
t.)
> =
> =
> Thanks,
> =
> wdoekes
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1775/">https://reviewboard.asterisk.org/r/1775/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As far as I can tell, \
the change to set peeraccount was wrong. All the other places that create an \
outgoing channel set the accountcode from the initiating channel.</pre> <br />
<p>- rmudgett</p>
<br />
<p>On February 28th, 2012, 2:51 p.m., wdoekes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By wdoekes.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2012, 2:51 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">r203638 | russell | 2009-06-26 17:28:53 +0200 (Fri, 26 Jun 2009) | 14 \
lines added the CEL event logging subsystem.
When this got added to trunk, the bug of ASTERISK-19384 started to appear.
jamicque spotted the difference between peeraccount and account in app_dial:
- ast_string_field_set(tc, accountcode, chan->accountcode);
+ if (!ast_strlen_zero(chan->accountcode)) {
+ ast_string_field_set(tc, peeraccount, chan->accountcode);
+ }
He attached accountcode.patch (License #6033) to the bugreport which changes that \
peeraccount into accountcode.
Was this a typo? Or was this meant to be changed?
If we apply the patch, the expected CDR behaviour with regards to the accountcode is \
restored.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">10 out of 10 of the testsuite cdr tests that run on my system still run \
successfully after applying the patch.
And now the 11th test (r1765) runs succesfully some of the time. (Only sometimes \
because of the undefined CDR order, this has to be fixed in the test.) </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-19384">ASTERISK-19384</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/1.8/apps/app_dial.c <span style="color: grey">(357402)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1775/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic