[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] Allow res_calendar to be unloaded
From: "Mark Michelson" <reviewboard () asterisk ! org>
Date: 2012-01-31 2:58:51
Message-ID: 20120131025851.18474.75064 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1657/#review5361
-----------------------------------------------------------
Ship it!
Good to go!
- Mark
On Jan. 30, 2012, 6:40 p.m., Terry Wilson wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1657/
> -----------------------------------------------------------
> =
> (Updated Jan. 30, 2012, 6:40 p.m.)
> =
> =
> Review request for Asterisk Developers.
> =
> =
> Summary
> -------
> =
> I have seen res_calendar modules contribute to issues with core stop grac=
efully in part because res_calendar doesn't really unload or take care of t=
he refresh thread that it spawns. There have been some non-calendar-related=
improvements that make the crash that was happening go away, but it is sti=
ll very ugly for the module to not clean up after itself. This patch makes =
res_calendar unloadable and unloads the dependent calendar modules during i=
ts unload. =
> =
> The issue is only tangentially related to ASTERISK-16744, but it is what =
prompted me to go ahead and write the patch. Reloads are still handled thro=
ugh the main res_calendar module.
> =
> =
> This addresses bug ASTERISK-16744.
> https://issues.asterisk.org/jira/browse/ASTERISK-16744
> =
> =
> Diffs
> -----
> =
> /trunk/res/res_calendar.c 353417 =
> =
> Diff: https://reviewboard.asterisk.org/r/1657/diff
> =
> =
> Testing
> -------
> =
> module unload res_calendar.so works, and the calendar tech modules are al=
so unloaded. Loading the res_calendar module then a tech module creates the=
proper calendar entries from the config.
> =
> =
> Thanks,
> =
> Terry
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1657/">https://reviewboard.asterisk.org/r/1657/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good to go!</pre> <br \
/>
<p>- Mark</p>
<br />
<p>On January 30th, 2012, 6:40 p.m., Terry Wilson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Terry Wilson.</div>
<p style="color: grey;"><i>Updated Jan. 30, 2012, 6:40 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have seen res_calendar modules contribute to issues with core stop \
gracefully in part because res_calendar doesn't really unload or take care of the \
refresh thread that it spawns. There have been some non-calendar-related improvements \
that make the crash that was happening go away, but it is still very ugly for the \
module to not clean up after itself. This patch makes res_calendar unloadable and \
unloads the dependent calendar modules during its unload.
The issue is only tangentially related to ASTERISK-16744, but it is what prompted me \
to go ahead and write the patch. Reloads are still handled through the main \
res_calendar module.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">module unload res_calendar.so works, and the calendar tech modules are \
also unloaded. Loading the res_calendar module then a tech module creates the proper \
calendar entries from the config.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-16744">ASTERISK-16744</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/res/res_calendar.c <span style="color: grey">(353417)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1657/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic