[prev in list] [next in list] [prev in thread] [next in thread]
List: asterisk-dev
Subject: Re: [asterisk-dev] [Code Review] RFC3261 Section 8.1.1.5. The sequence number value MUST be expressi
From: "Mark Michelson" <reviewboard () asterisk ! org>
Date: 2012-01-30 20:57:18
Message-ID: 20120130205718.18391.29468 () hotblack ! digium ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1699/#review5357
-----------------------------------------------------------
Ship it!
Like Terry said, try not to make extraneous changes beyond the scope of the review if \
possible. Still, go ahead and commit since there's nothing _wrong_ here.
- Mark
On Jan. 27, 2012, 3:34 p.m., Alec Davis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1699/
> -----------------------------------------------------------
>
> (Updated Jan. 27, 2012, 3:34 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> RFC 3261 Section 8.1 documents intial value of CSeq and it's maximum out side of a \
> dialog. 8.1 UAC Behavior
> This section covers UAC behavior outside of a dialog.
> 8.1.1.5
> .. "The sequence number value MUST be expressible as a 32-bit unsigned integer and \
> MUST be less than 2**31." "Section 12.2.1.1 discusses construction of the CSeq for \
> requests within a dialog."
> RFC 3261 Section 12.2.1.1, documents the maximum value a seqno can get to within a \
> dialog, 2^32-1. (136 years equals 2^32 seconds). "If the local sequence number is \
> empty, an initial value MUST be chosen using the guidelines of \
> Section 8.1.1.5"
> .. "With a length of 32 bits, a client could generate, within a single call, one \
> request a second for about 136 years before needing to wrap around."
> ===============================================================================
>
> By defining INITIAL_CSEQ to values near the maximum, it can clearly be seen that \
> asterisk will represent the cseqno as negative numbers as %d is used in most \
> places.
> //#define INITIAL_CSEQ 101 /*!< Our initial sip sequence number */
> #define INITIAL_CSEQ 2147483640 /*!< Our initial sip sequence number \
> */ #define INITIAL_CSEQ 4294967290UL /*!< Our initial sip sequence \
> number */
> Examples below after a few messages with INITIAL_CSEQ set to 214783640
>
> ...
> Call-ID: d469d55c9e9e81ae@192.168.y.yyy
> CSeq: -2147483639 NOTIFY
> User-Agent: Asterisk PBX SVN-trunk-r352864M
> Subscription-State: active
> Event: dialog
> Content-Type: application/dialog-info+xml
> Content-Length: 206
>
> <?xml version="1.0"?>
> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="16" state="full" \
> entity="sip:8612@192.168.x.xxx">
> ...
> Call-ID: 7d1d964b7867eee008705e1e64386d4e@192.168.x.xxx:5060
> CSeq: -5 NOTIFY
> User-Agent: Asterisk PBX SVN-trunk-r352864M
> Event: message-summary
> Content-Type: application/simple-message-summary
> Content-Length: 92
>
> Messages-Waiting: no
> Message-Account: sip:asterisk@192.168.x.xxx
> Voice-Message: 0/0 (0/0)
>
>
>
>
> Diffs
> -----
>
> trunk/channels/chan_sip.c 352913
> trunk/channels/sip/include/dialog.h 352913
> trunk/channels/sip/include/sip.h 352913
>
> Diff: https://reviewboard.asterisk.org/r/1699/diff
>
>
> Testing
> -------
>
> Noted that Notify for BLF and MWI, that the CSeq numbers now wrapped around to 0.
>
> After using the 2nd maximum of 2^32 minus a few (#define INITIAL_CSEQ \
> 4294967290UL) phones, BLF and MWI still workign as normal.
> Previously the BLF would stop functioning after the minus values were reached.
> Now it wraps around from 4294967295 to 0, as below.
>
> Call-ID: c2aaba2919cfcd4a@192.168.y.yyy
> CSeq: 4294967295 NOTIFY
> User-Agent: Asterisk PBX SVN-trunk-r352864M
> Subscription-State: active
> Event: dialog
> Content-Type: application/dialog-info+xml
> Content-Length: 205
>
> <?xml version="1.0"?>
> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="4" state="full" \
> entity="sip:8612@192.168.x.xxx"> <dialog id="8612">
>
> ...
> Call-ID: c2aaba2919cfcd4a@192.168.y.yyy
> CSeq: 0 NOTIFY
> User-Agent: Asterisk PBX SVN-trunk-r352864M
> Subscription-State: active
> Event: dialog
> Content-Type: application/dialog-info+xml
> Content-Length: 205
>
> <?xml version="1.0"?>
> <dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" version="5" state="full" \
> entity="sip:8612@192.168.x.xxx"> <dialog id="8612">
>
>
> Thanks,
>
> Alec
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/1699/">https://reviewboard.asterisk.org/r/1699/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Like Terry said, try not \
to make extraneous changes beyond the scope of the review if possible. Still, go \
ahead and commit since there's nothing _wrong_ here.</pre> <br />
<p>- Mark</p>
<br />
<p>On January 27th, 2012, 3:34 p.m., Alec Davis wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Alec Davis.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2012, 3:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">RFC 3261 Section 8.1 documents intial value of CSeq and it's maximum \
out side of a dialog. 8.1 UAC Behavior
This section covers UAC behavior outside of a dialog.
8.1.1.5
.. "The sequence number value MUST be expressible as a 32-bit unsigned \
integer and MUST be less than 2**31."
"Section 12.2.1.1 discusses construction of the CSeq for requests within a \
dialog."
RFC 3261 Section 12.2.1.1, documents the maximum value a seqno can get to within a \
dialog, 2^32-1. (136 years equals 2^32 seconds). "If the local sequence number \
is empty, an initial value MUST be chosen using the guidelines of Section \
8.1.1.5"
.. "With a length of 32 bits, a client could generate, within a single call, \
one request a second for about 136 years before needing to wrap around."
===============================================================================
By defining INITIAL_CSEQ to values near the maximum, it can clearly be seen that \
asterisk will represent the cseqno as negative numbers as %d is used in most places.
//#define INITIAL_CSEQ 101 /*!< Our initial sip sequence number */
#define INITIAL_CSEQ 2147483640 /*!< Our initial sip sequence number \
*/ #define INITIAL_CSEQ 4294967290UL /*!< Our initial sip sequence \
number */
Examples below after a few messages with INITIAL_CSEQ set to 214783640
...
Call-ID: d469d55c9e9e81ae@192.168.y.yyy
CSeq: -2147483639 NOTIFY
User-Agent: Asterisk PBX SVN-trunk-r352864M
Subscription-State: active
Event: dialog
Content-Type: application/dialog-info+xml
Content-Length: 206
<?xml version="1.0"?>
<dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" \
version="16" state="full" \
entity="sip:8612@192.168.x.xxx">
...
Call-ID: 7d1d964b7867eee008705e1e64386d4e@192.168.x.xxx:5060
CSeq: -5 NOTIFY
User-Agent: Asterisk PBX SVN-trunk-r352864M
Event: message-summary
Content-Type: application/simple-message-summary
Content-Length: 92
Messages-Waiting: no
Message-Account: sip:asterisk@192.168.x.xxx
Voice-Message: 0/0 (0/0)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Noted that Notify for BLF and MWI, that the CSeq numbers now wrapped \
around to 0.
After using the 2nd maximum of 2^32 minus a few (#define INITIAL_CSEQ \
4294967290UL) phones, BLF and MWI still workign as normal.
Previously the BLF would stop functioning after the minus values were reached.
Now it wraps around from 4294967295 to 0, as below.
Call-ID: c2aaba2919cfcd4a@192.168.y.yyy
CSeq: 4294967295 NOTIFY
User-Agent: Asterisk PBX SVN-trunk-r352864M
Subscription-State: active
Event: dialog
Content-Type: application/dialog-info+xml
Content-Length: 205
<?xml version="1.0"?>
<dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" \
version="4" state="full" \
entity="sip:8612@192.168.x.xxx"> <dialog id="8612">
...
Call-ID: c2aaba2919cfcd4a@192.168.y.yyy
CSeq: 0 NOTIFY
User-Agent: Asterisk PBX SVN-trunk-r352864M
Subscription-State: active
Event: dialog
Content-Type: application/dialog-info+xml
Content-Length: 205
<?xml version="1.0"?>
<dialog-info xmlns="urn:ietf:params:xml:ns:dialog-info" \
version="5" state="full" \
entity="sip:8612@192.168.x.xxx"> <dialog id="8612">
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/channels/chan_sip.c <span style="color: grey">(352913)</span></li>
<li>trunk/channels/sip/include/dialog.h <span style="color: \
grey">(352913)</span></li>
<li>trunk/channels/sip/include/sip.h <span style="color: grey">(352913)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/1699/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic