'Re: [asterisk-dev] [Code Review] Fix asttest's Asterisk version extraction'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Fix asttest's Asterisk version extraction
From:       "Matt Jordan" <reviewboard () asterisk ! org>
Date:       2012-01-29 3:40:53
Message-ID: 20120129034053.5461.44796 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1701/
-----------------------------------------------------------

(Updated Jan. 28, 2012, 9:40 p.m.)

Review request for Asterisk Developers.

Summary
-------

This patch changes how the lua-based tests determine the Asterisk version. =
 Previously, like the version.py library, the astlib.lua library was extrac=
ting this from the version.h header file.  Now it also spawns an Asterisk p=
rocess with the '-V' command line switch and reads the version from the out=
put.

This should resolve the failing tests in trunk:
* rfc2833_dtmf_detect
* manager/action-events-response
* queues/position_priority_maxlen
* cdr/blind-transfer-accountcode

This patch also addresses Russell and Walter's last comments on version.py =
in https://reviewboard.asterisk.org/r/1695/.  Specifically, it re-raises ca=
ught OSError exceptions after logging them, and places the setting of the s=
tatic variable in a private method.

Diffs (updated)
-----

  /asterisk/trunk/asttest/lib/lua/astlib.lua 3021 =

  /asterisk/trunk/lib/python/asterisk/version.py 3021 =

Diff: https://reviewboard.asterisk.org/r/1701/diff

Testing
-------

Ran on local development machine; all currently failing trunk tests passed.

Thanks,

Matt

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1701/">https://reviewboard.asterisk.org/r/1701/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>

<p style="color: grey;"><i>Updated Jan. 28, 2012, 9:40 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch changes how the lua-based tests determine the Asterisk \
version.  Previously, like the version.py library, the astlib.lua library was \
extracting this from the version.h header file.  Now it also spawns an Asterisk \
process with the &#39;-V&#39; command line switch and reads the version from the \
output.

This should resolve the failing tests in trunk:
* rfc2833_dtmf_detect
* manager/action-events-response
* queues/position_priority_maxlen
* cdr/blind-transfer-accountcode

This patch also addresses Russell and Walter&#39;s last comments on version.py in \
https://reviewboard.asterisk.org/r/1695/.  Specifically, it re-raises caught OSError \
exceptions after logging them, and places the setting of the static variable in a \
private method.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ran on local development machine; all currently failing trunk tests \
passed.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>/asterisk/trunk/asttest/lib/lua/astlib.lua <span style="color: \
grey">(3021)</span></li>

 <li>/asterisk/trunk/lib/python/asterisk/version.py <span style="color: \
grey">(3021)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1701/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 