'Re: [asterisk-dev] [Code Review] Audit of ao2_iterator_init() usage for v1.8'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       asterisk-dev
Subject:    Re: [asterisk-dev] [Code Review] Audit of ao2_iterator_init() usage for v1.8
From:       "Mark Michelson" <reviewboard () asterisk ! org>
Date:       2012-01-27 17:15:09
Message-ID: 20120127171509.10114.95941 () hotblack ! digium ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/1697/#review5337
-----------------------------------------------------------

Ship it!

Yes!

- Mark

On Jan. 27, 2012, 10:18 a.m., rmudgett wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/1697/
> -----------------------------------------------------------
> =

> (Updated Jan. 27, 2012, 10:18 a.m.)
> =

> =

> Review request for Asterisk Developers and Mark Michelson.
> =

> =

> Summary
> -------
> =

> I audited the usage of the ao2_iterator_init() function in the v1.8 code =
base.
> =

> I checked that the iterator was destroyed and that the current iteration =
object reference was not leaked.
> =

> This patch fixes numerous reference leaks and missing ao2_iterator_destro=
y() calls as a result.
> =

> =

> Diffs
> -----
> =

>   /branches/1.8/apps/app_chanspy.c 352916 =

>   /branches/1.8/apps/app_queue.c 352916 =

>   /branches/1.8/channels/chan_iax2.c 352916 =

>   /branches/1.8/channels/chan_sip.c 352916 =

>   /branches/1.8/include/asterisk/indications.h 352916 =

>   /branches/1.8/main/indications.c 352916 =

>   /branches/1.8/main/pbx.c 352916 =

>   /branches/1.8/main/taskprocessor.c 352916 =

>   /branches/1.8/res/res_odbc.c 352916 =

>   /branches/1.8/res/res_srtp.c 352916 =

>   /branches/1.8/res/snmp/agent.c 352916 =

> =

> Diff: https://reviewboard.asterisk.org/r/1697/diff
> =

> =

> Testing
> -------
> =

> It compiles. :)
> =

> =

> Thanks,
> =

> rmudgett
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://reviewboard.asterisk.org/r/1697/">https://reviewboard.asterisk.org/r/1697/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes!</pre>  <br />

<p>- Mark</p>

<br />
<p>On January 27th, 2012, 10:18 a.m., rmudgett wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://reviewboard.asterisk.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Asterisk Developers and Mark Michelson.</div>
<div>By rmudgett.</div>

<p style="color: grey;"><i>Updated Jan. 27, 2012, 10:18 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I audited the usage of the ao2_iterator_init() function in the v1.8 code \
base.

I checked that the iterator was destroyed and that the current iteration object \
reference was not leaked.

This patch fixes numerous reference leaks and missing ao2_iterator_destroy() calls as \
a result.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">It compiles. :)</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>/branches/1.8/apps/app_chanspy.c <span style="color: grey">(352916)</span></li>

 <li>/branches/1.8/apps/app_queue.c <span style="color: grey">(352916)</span></li>

 <li>/branches/1.8/channels/chan_iax2.c <span style="color: \
grey">(352916)</span></li>

 <li>/branches/1.8/channels/chan_sip.c <span style="color: grey">(352916)</span></li>

 <li>/branches/1.8/include/asterisk/indications.h <span style="color: \
grey">(352916)</span></li>

 <li>/branches/1.8/main/indications.c <span style="color: grey">(352916)</span></li>

 <li>/branches/1.8/main/pbx.c <span style="color: grey">(352916)</span></li>

 <li>/branches/1.8/main/taskprocessor.c <span style="color: \
grey">(352916)</span></li>

 <li>/branches/1.8/res/res_odbc.c <span style="color: grey">(352916)</span></li>

 <li>/branches/1.8/res/res_srtp.c <span style="color: grey">(352916)</span></li>

 <li>/branches/1.8/res/snmp/agent.c <span style="color: grey">(352916)</span></li>

</ul>

<p><a href="https://reviewboard.asterisk.org/r/1697/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
   http://lists.digium.com/mailman/listinfo/asterisk-dev

[prev in list] [next in list] [prev in thread] [next in thread] 